Remove --unlimited-quota-for-indexeddb. Increase incognito quota.

Remove --unlimited-quota-for-indexeddb. Increase incognito quota.

Incognito / SQLite's quota is now 50mb.  We'll have to figure out what to do for quota for LevelDB's incognito mode when it's implemented.

BUG=94187
TEST=llvm/Debug/browser_tests --gtest_filter=IndexedDB*


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98522

[dgrogan, 2011-08-25 02:06:21]

Michael, could you review this?

http://codereview.chromium.org/7745011/diff/1/content/browser/in_process_webk...
File content/browser/in_process_webkit/indexed_db_dispatcher_host.cc (left):

http://codereview.chromium.org/7745011/diff/1/content/browser/in_process_webk...
content/browser/in_process_webkit/indexed_db_dispatcher_host.cc:215: if
(Context()->IsUnlimitedStorageGranted(origin_url) ||
IsUnlimitedStorageGranted is handled by the QuotaManager.

[michaeln, 2011-08-25 18:23:17]

LGTM

http://codereview.chromium.org/7745011/diff/2001/content/browser/in_process_w...
File content/browser/in_process_webkit/indexed_db_dispatcher_host.cc (left):

http://codereview.chromium.org/7745011/diff/2001/content/browser/in_process_w...
content/browser/in_process_webkit/indexed_db_dispatcher_host.cc:212:
DCHECK(kDefaultQuota == params.maximum_size);
since the params.maximum_size value isn't used, it would be good to remove that
from the struct at some point

http://codereview.chromium.org/7745011/diff/2001/content/browser/in_process_w...
File content/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right):

http://codereview.chromium.org/7745011/diff/2001/content/browser/in_process_w...
content/browser/in_process_webkit/indexed_db_dispatcher_host.cc:50: static const
uint64 kDefaultQuota = 50 * 1024 * 1024;
I wonder about the name of this variable? It only affects the sqlite backend
which is only used in incognito mode. It doesn't apply to the usual case. Maybe
rename it to something more suggestive of how its used...
kIncognitoSqliteBackendQuota?

Also, could be a local const in the OnIDBFactoryOpen() method since that's the
only place it's used.

[dgrogan, 2011-08-25 23:28:58]

http://codereview.chromium.org/7745011/diff/2001/content/browser/in_process_w...
File content/browser/in_process_webkit/indexed_db_dispatcher_host.cc (left):

http://codereview.chromium.org/7745011/diff/2001/content/browser/in_process_w...
content/browser/in_process_webkit/indexed_db_dispatcher_host.cc:212:
DCHECK(kDefaultQuota == params.maximum_size);
On 2011/08/25 18:23:17, michaeln wrote:
> since the params.maximum_size value isn't used, it would be good to remove
that
> from the struct at some point

Removed.

http://codereview.chromium.org/7745011/diff/2001/content/browser/in_process_w...
File content/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right):

http://codereview.chromium.org/7745011/diff/2001/content/browser/in_process_w...
content/browser/in_process_webkit/indexed_db_dispatcher_host.cc:50: static const
uint64 kDefaultQuota = 50 * 1024 * 1024;
On 2011/08/25 18:23:17, michaeln wrote:
> I wonder about the name of this variable? It only affects the sqlite backend
> which is only used in incognito mode. It doesn't apply to the usual case.
Maybe
> rename it to something more suggestive of how its used...
> kIncognitoSqliteBackendQuota?
> 
> Also, could be a local const in the OnIDBFactoryOpen() method since that's the
> only place it's used.

Done.

[michaeln, 2011-08-26 02:10:26]

still lgtm... thnx!

[commit-bot: I haz the power, 2011-08-26 02:29:49]

Can't apply patch for file
content/browser/in_process_webkit/indexed_db_context.cc.
While running patch -p1 --forward --force;
patching file content/browser/in_process_webkit/indexed_db_context.cc
Hunk #1 FAILED at 156.
1 out of 1 hunk FAILED -- saving rejects to file
content/browser/in_process_webkit/indexed_db_context.cc.rej

[commit-bot: I haz the power, 2011-08-26 05:14:42]

Presubmit check for 7745011-2004 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
content/renderer/indexed_db_dispatcher.cc,content/renderer/renderer_webidbfactory_impl.h,content/renderer/renderer_webidbfactory_impl.cc,content/renderer/indexed_db_dispatcher.h,content/common/content_switches.h,content/common/content_switches.cc,content/common/indexed_db_messages.h

Presubmit checks took 3.1s to calculate.

[dgrogan, 2011-08-26 18:28:24]

+jam

John, could you look at this as an OWNER of content/renderer and content/common?

Thanks!

[jam, 2011-08-26 20:53:40]

lgtm

[commit-bot: I haz the power, 2011-08-26 23:40:56]

Change committed as 98522