Initial work for UDP Pepper API

ppapi/proxy/ppapi_messages.h

Index: ppapi/proxy/ppapi_messages.h
diff --git a/ppapi/proxy/ppapi_messages.h b/ppapi/proxy/ppapi_messages.h
index 4611a4fc3d47fbb5d2fe0d388caebd6b8c80b8d8..7e781dd5822d7aac6061defdc0ee0bffd7eb09aa 100644
--- a/ppapi/proxy/ppapi_messages.h
+++ b/ppapi/proxy/ppapi_messages.h
@@ -29,6 +29,7 @@
 #include "ppapi/c/pp_size.h"
 #include "ppapi/c/dev/pp_video_dev.h"
 #include "ppapi/c/private/ppb_flash_tcp_socket.h"
+#include "ppapi/c/private/ppb_flash_udp_socket.h"

[yzshen1, 2011/09/17 02:10:07]

We probably don't need this include.
The reason we include ppb_flash_tcp_socket.h is for PP_Flash_NetAddress.

[mtilburg, 2011/09/21 01:46:43]

Done.

 #include "ppapi/proxy/ppapi_param_traits.h"
 #include "ppapi/proxy/ppapi_proxy_export.h"
 #include "ppapi/proxy/serialized_flash_menu.h"
@@ -263,6 +264,24 @@ IPC_MESSAGE_ROUTED4(PpapiMsg_PPBFlashTCPSocket_WriteACK,
                     bool /* succeeded */,
                     int32_t /* bytes_written */)
 
+// PPB_Flash_UDPSocket
+IPC_MESSAGE_ROUTED4(PpapiMsg_PPBFlashUDPSocket_BindACK,
+                    uint32 /* plugin_dispatcher_id */,
+                    uint32 /* socket_id */,
+                    bool /* succeeded */,
+                    int32_t /* return value */)

[yzshen1, 2011/09/17 02:10:07]

You don't need this return value:
1) currently it always passes back 0 or net::OK (which is also 0).
2) this value is directly passed to a PPAPI completion callback, which regards
the input as a Pepper error code. It happens to be PP_OK. But this is actually a
reinterpret cast.
3) because of (1)&(2), the completion callback reports PP_OK no matter Bind is
successful or not.

You could remove this return value, and call the completion callback:
PP_RunAndClearCompletionCallback(the_callback, succeeded ? PP_OK : PP_FAILED);

[mtilburg, 2011/09/21 01:46:43]

Done.

+IPC_MESSAGE_ROUTED5(PpapiMsg_PPBFlashUDPSocket_RecvFromACK,
+                    uint32 /* plugin_dispatcher_id */,
+                    uint32 /* socket_id */,
+                    bool /* succeeded */,
+                    std::string /* data */,
+                    PP_Flash_NetAddress /* remote_addr */)
+IPC_MESSAGE_ROUTED4(PpapiMsg_PPBFlashUDPSocket_SendToACK,
+                    uint32 /* plugin_dispatcher_id */,
+                    uint32 /* socket_id */,
+                    bool /* succeeded */,
+                    int32_t /* bytes_written */)
+
 // PPB_Graphics2D.
 IPC_MESSAGE_ROUTED2(PpapiMsg_PPBGraphics2D_FlushACK,
                     ppapi::HostResource /* graphics_2d */,
@@ -740,6 +759,25 @@ IPC_MESSAGE_CONTROL2(PpapiHostMsg_PPBFlashTCPSocket_Write,
 IPC_MESSAGE_CONTROL1(PpapiHostMsg_PPBFlashTCPSocket_Disconnect,
                      uint32 /* socket_id */)
 
+// PPB_Flash_UDPSocket
+IPC_SYNC_MESSAGE_CONTROL3_1(PpapiHostMsg_PPBFlashUDPSocket_Create,
+                            int32 /* routing_id */,
+                            uint32 /* plugin_dispatcher_id */,
+                            int32_t /* family */,
+                            uint32 /* socket_id */ )

[yzshen1, 2011/09/17 02:10:07]

line 767, 779: Please be consistent: no space after */

[mtilburg, 2011/09/21 01:46:43]

Done.

+IPC_MESSAGE_CONTROL2(PpapiHostMsg_PPBFlashUDPSocket_Bind,
+                     uint32  /* socket_id */,

[yzshen1, 2011/09/17 02:10:07]

line 769, 772, 775, 779: Should be one space after uint32.

[mtilburg, 2011/09/21 01:46:43]

Done.

+                     PP_Flash_NetAddress /* net_addr */)
+IPC_MESSAGE_CONTROL2(PpapiHostMsg_PPBFlashUDPSocket_RecvFrom,
+                     uint32  /* socket_id */,
+                     int32_t /* num_bytes */)
+IPC_MESSAGE_CONTROL3(PpapiHostMsg_PPBFlashUDPSocket_SendTo,
+                     uint32  /* socket_id */,
+                     std::string /* data */,
+                     PP_Flash_NetAddress /* net_addr */)
+IPC_MESSAGE_CONTROL1(PpapiHostMsg_PPBFlashUDPSocket_Disconnect,
+                     uint32  /* socket_id */ )
+
 // PPB_Font.
 IPC_SYNC_MESSAGE_CONTROL0_1(PpapiHostMsg_PPBFont_GetFontFamilies,
                             std::string /* result */)