Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 7745002: GetViewBounds should use screen coordinates but not parents. (Closed)

Created:
9 years, 4 months ago by oshima
Modified:
9 years, 4 months ago
Reviewers:
tony, brettw
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

GetViewBounds should use screen coordinates but not parents. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98189

Patch Set 1 #

Patch Set 2 : " #

Patch Set 3 : use requested_size_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 2 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
oshima
Tony, it looks to me that GetViewBounds on linux/gtk is using parent's coordinates but not ...
9 years, 4 months ago (2011-08-24 23:04:19 UTC) #1
tony
LGTM. Was GetViewBounds used for anything before your refactor? Possibly not.
9 years, 4 months ago (2011-08-24 23:21:55 UTC) #2
oshima
On 2011/08/24 23:21:55, tony wrote: > LGTM. Was GetViewBounds used for anything before your refactor? ...
9 years, 4 months ago (2011-08-25 00:01:16 UTC) #3
oshima
+brettw, asking for OWNER's approval
9 years, 4 months ago (2011-08-25 04:30:44 UTC) #4
brettw
9 years, 4 months ago (2011-08-25 04:44:04 UTC) #5
LGTM stubber ramp

Powered by Google App Engine
This is Rietveld 408576698