Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Side by Side Diff: chrome/browser/bookmarks/bookmark_context_menu_controller.cc

Issue 7744055: bookmarks: Fix an obvious typo in IDS_BOOMARK_*. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/bookmarks/bookmark_context_menu_controller.h" 5 #include "chrome/browser/bookmarks/bookmark_context_menu_controller.h"
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "chrome/app/chrome_command_ids.h" 8 #include "chrome/app/chrome_command_ids.h"
9 #include "chrome/browser/bookmarks/bookmark_editor.h" 9 #include "chrome/browser/bookmarks/bookmark_editor.h"
10 #include "chrome/browser/bookmarks/bookmark_folder_editor_controller.h" 10 #include "chrome/browser/bookmarks/bookmark_folder_editor_controller.h"
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 } 44 }
45 45
46 BookmarkContextMenuController::~BookmarkContextMenuController() { 46 BookmarkContextMenuController::~BookmarkContextMenuController() {
47 if (model_) 47 if (model_)
48 model_->RemoveObserver(this); 48 model_->RemoveObserver(this);
49 } 49 }
50 50
51 void BookmarkContextMenuController::BuildMenu() { 51 void BookmarkContextMenuController::BuildMenu() {
52 if (selection_.size() == 1 && selection_[0]->is_url()) { 52 if (selection_.size() == 1 && selection_[0]->is_url()) {
53 AddItem(IDC_BOOKMARK_BAR_OPEN_ALL, 53 AddItem(IDC_BOOKMARK_BAR_OPEN_ALL,
54 IDS_BOOMARK_BAR_OPEN_IN_NEW_TAB); 54 IDS_BOOKMARK_BAR_OPEN_IN_NEW_TAB);
55 AddItem(IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW, 55 AddItem(IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW,
56 IDS_BOOMARK_BAR_OPEN_IN_NEW_WINDOW); 56 IDS_BOOKMARK_BAR_OPEN_IN_NEW_WINDOW);
57 AddItem(IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO, 57 AddItem(IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO,
58 IDS_BOOMARK_BAR_OPEN_INCOGNITO); 58 IDS_BOOKMARK_BAR_OPEN_INCOGNITO);
59 } else { 59 } else {
60 AddItem(IDC_BOOKMARK_BAR_OPEN_ALL, IDS_BOOMARK_BAR_OPEN_ALL); 60 AddItem(IDC_BOOKMARK_BAR_OPEN_ALL, IDS_BOOKMARK_BAR_OPEN_ALL);
61 AddItem(IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW, 61 AddItem(IDC_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW,
62 IDS_BOOMARK_BAR_OPEN_ALL_NEW_WINDOW); 62 IDS_BOOKMARK_BAR_OPEN_ALL_NEW_WINDOW);
63 AddItem(IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO, 63 AddItem(IDC_BOOKMARK_BAR_OPEN_ALL_INCOGNITO,
64 IDS_BOOMARK_BAR_OPEN_ALL_INCOGNITO); 64 IDS_BOOKMARK_BAR_OPEN_ALL_INCOGNITO);
65 } 65 }
66 66
67 AddSeparator(); 67 AddSeparator();
68 if (selection_.size() == 1 && selection_[0]->is_folder()) { 68 if (selection_.size() == 1 && selection_[0]->is_folder()) {
69 AddItem(IDC_BOOKMARK_BAR_RENAME_FOLDER, IDS_BOOKMARK_BAR_RENAME_FOLDER); 69 AddItem(IDC_BOOKMARK_BAR_RENAME_FOLDER, IDS_BOOKMARK_BAR_RENAME_FOLDER);
70 } else { 70 } else {
71 AddItem(IDC_BOOKMARK_BAR_EDIT, IDS_BOOKMARK_BAR_EDIT); 71 AddItem(IDC_BOOKMARK_BAR_EDIT, IDS_BOOKMARK_BAR_EDIT);
72 } 72 }
73 73
74 AddSeparator(); 74 AddSeparator();
75 AddItem(IDC_CUT, IDS_CUT); 75 AddItem(IDC_CUT, IDS_CUT);
76 AddItem(IDC_COPY, IDS_COPY); 76 AddItem(IDC_COPY, IDS_COPY);
77 AddItem(IDC_PASTE, IDS_PASTE); 77 AddItem(IDC_PASTE, IDS_PASTE);
78 78
79 AddSeparator(); 79 AddSeparator();
80 AddItem(IDC_BOOKMARK_BAR_REMOVE, IDS_BOOKMARK_BAR_REMOVE); 80 AddItem(IDC_BOOKMARK_BAR_REMOVE, IDS_BOOKMARK_BAR_REMOVE);
81 81
82 AddSeparator(); 82 AddSeparator();
83 AddItem(IDC_BOOKMARK_BAR_ADD_NEW_BOOKMARK, IDS_BOOMARK_BAR_ADD_NEW_BOOKMARK); 83 AddItem(IDC_BOOKMARK_BAR_ADD_NEW_BOOKMARK, IDS_BOOKMARK_BAR_ADD_NEW_BOOKMARK);
84 AddItem(IDC_BOOKMARK_BAR_NEW_FOLDER, IDS_BOOMARK_BAR_NEW_FOLDER); 84 AddItem(IDC_BOOKMARK_BAR_NEW_FOLDER, IDS_BOOKMARK_BAR_NEW_FOLDER);
85 85
86 AddSeparator(); 86 AddSeparator();
87 AddItem(IDC_BOOKMARK_MANAGER, IDS_BOOKMARK_MANAGER); 87 AddItem(IDC_BOOKMARK_MANAGER, IDS_BOOKMARK_MANAGER);
88 AddCheckboxItem(IDC_BOOKMARK_BAR_ALWAYS_SHOW, IDS_SHOW_BOOKMARK_BAR); 88 AddCheckboxItem(IDC_BOOKMARK_BAR_ALWAYS_SHOW, IDS_SHOW_BOOKMARK_BAR);
89 } 89 }
90 90
91 void BookmarkContextMenuController::AddItem(int id, int localization_id) { 91 void BookmarkContextMenuController::AddItem(int id, int localization_id) {
92 menu_model_->AddItemWithStringId(id, localization_id); 92 menu_model_->AddItemWithStringId(id, localization_id);
93 } 93 }
94 94
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 delegate_->CloseMenu(); 316 delegate_->CloseMenu();
317 } 317 }
318 318
319 bool BookmarkContextMenuController::HasURLs() const { 319 bool BookmarkContextMenuController::HasURLs() const {
320 for (size_t i = 0; i < selection_.size(); ++i) { 320 for (size_t i = 0; i < selection_.size(); ++i) {
321 if (bookmark_utils::NodeHasURLs(selection_[i])) 321 if (bookmark_utils::NodeHasURLs(selection_[i]))
322 return true; 322 return true;
323 } 323 }
324 return false; 324 return false;
325 } 325 }
OLDNEW
« no previous file with comments | « chrome/browser/bookmarks/bookmark_codec.cc ('k') | chrome/browser/bookmarks/bookmark_folder_editor_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698