src/x64/lithium-codegen-x64.cc - Issue 7744052: Generated code for substring slices in ia32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-codegen-x64.cc

Issue 7744052: Generated code for substring slices in ia32. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Another set of small changes. Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/lithium-codegen-x64.cc

diff --git a/src/x64/lithium-codegen-x64.cc b/src/x64/lithium-codegen-x64.cc

index 76a9453b79f680ca5823293a5cd6cde06f220f78..c182413c60f294c2d4db3b2416e07c00ad47b45f 100644

--- a/src/x64/lithium-codegen-x64.cc

+++ b/src/x64/lithium-codegen-x64.cc

@@ -3217,8 +3217,6 @@ void LCodeGen::DoStringCharCodeAt(LStringCharCodeAt* instr) {

// Dispatch on the indirect string shape: slice or cons.

Label cons_string;

- const uint32_t kSlicedNotConsMask = kSlicedStringTag & ~kConsStringTag;

- ASSERT(IsPowerOf2(kSlicedNotConsMask) && kSlicedNotConsMask != 0);

__ testb(result, Immediate(kSlicedNotConsMask));

__ j(zero, &cons_string, Label::kNear);