Avoid null dereference in updateStatistics().

remoting/webapp/me2mom/remoting.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var remoting = remoting || {};
 
 (function() {
 'use strict';
 
 window.addEventListener('blur', pluginLostFocus_, false);
@@ skipping 340 matching lines @@
 }
 
 remoting.cancelShare = function() {
   remoting.debug.log('Canceling share...');
   var plugin = document.getElementById(remoting.HOST_PLUGIN_ID);
   plugin.disconnect();
   disableTimeoutCountdown_();
 }
 
 function updateStatistics() {
+  if (!remoting.session)
+    return;

[Jamie, 2011/08/25 22:57:14]

I think I'd combine these with || rather than having two tests.

[Lambros, 2011/08/25 23:11:30]

I prefer to leave as-is, if that's OK.  I find constructs such as
  if (!X || !Y)
hard to understand.  Also, this would push the single if.. test over the 80-char
limit.

   if (remoting.session.state != remoting.ClientSession.State.CONNECTED)
     return;
   var stats = remoting.session.stats();
 
   var units = '';
   var videoBandwidth = stats['video_bandwidth'];
   if (videoBandwidth < 1024) {
     units = 'Bps';
   } else if (videoBandwidth < 1048576) {
     units = 'KiBps';
@@ skipping 259 matching lines @@
       return result;
     default:
       return NULL;
   }
 }
 
 }());
 
 // Shortcut to save typing now that this is the only way to show the debug log.
 var tdl = remoting.toggleDebugLog;