Issue 7744043: Avoid null dereference in updateStatistics().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7744043: Avoid null dereference in updateStatistics(). (Closed)

Created:
9 years, 4 months ago by Lambros

Modified:
9 years, 4 months ago

Reviewers:
Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Avoid null dereference in updateStatistics(). BUG=94101 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98350

Patch Set 1 #

Total comments: 2

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	remoting/webapp/me2mom/remoting.js	View		1 chunk	+2 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jamie

LTGM, with one optional suggestion. http://codereview.chromium.org/7744043/diff/1/remoting/webapp/me2mom/remoting.js File remoting/webapp/me2mom/remoting.js (right): http://codereview.chromium.org/7744043/diff/1/remoting/webapp/me2mom/remoting.js#newcode362 remoting/webapp/me2mom/remoting.js:362: return; I think I'd ...

9 years, 4 months ago (2011-08-25 22:57:14 UTC) #2

Lambros

http://codereview.chromium.org/7744043/diff/1/remoting/webapp/me2mom/remoting.js File remoting/webapp/me2mom/remoting.js (right): http://codereview.chromium.org/7744043/diff/1/remoting/webapp/me2mom/remoting.js#newcode362 remoting/webapp/me2mom/remoting.js:362: return; On 2011/08/25 22:57:14, Jamie wrote: > I think ...

9 years, 4 months ago (2011-08-25 23:11:30 UTC) #3

LGTM

Expand Messages | Collapse Messages