Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Unified Diff: chrome/test/base/chrome_test_suite.h

Issue 7744039: Switch ChromeTestSuite to the same convention as ContentTestSuite: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more fixing Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/chrome_test_suite.h
diff --git a/chrome/test/base/chrome_test_suite.h b/chrome/test/base/chrome_test_suite.h
index 1a52ecef16cc64c4118783fe696aec8826f9f910..14f2f7b662844015d6c2173bf6fb8ebce0476aad 100644
--- a/chrome/test/base/chrome_test_suite.h
+++ b/chrome/test/base/chrome_test_suite.h
@@ -8,39 +8,15 @@
#include <string>
-#include "build/build_config.h"
-
-#include "base/file_util.h"
-#include "base/memory/ref_counted.h"
-#include "base/path_service.h"
+#include "base/file_path.h"
+#include "base/memory/scoped_ptr.h"
#include "base/test/test_suite.h"
#include "chrome/app/scoped_ole_initializer.h"
-#include "chrome/browser/chrome_content_browser_client.h"
-#include "chrome/common/chrome_content_client.h"
-#include "testing/gtest/include/gtest/gtest.h"
-#include "net/base/mock_host_resolver.h"
-#include "net/base/net_util.h"
namespace base {
class StatsTable;
}
-// In many cases it may be not obvious that a test makes a real DNS lookup.
-// We generally don't want to rely on external DNS servers for our tests,
-// so this host resolver procedure catches external queries and returns a failed
-// lookup result.
-class LocalHostResolverProc : public net::HostResolverProc {
- public:
- LocalHostResolverProc();
- virtual ~LocalHostResolverProc();
-
- virtual int Resolve(const std::string& host,
- net::AddressFamily address_family,
- net::HostResolverFlags host_resolver_flags,
- net::AddressList* addrlist,
- int* os_error);
-};
-
class ChromeTestSuite : public base::TestSuite {
public:
ChromeTestSuite(int argc, char** argv);
@@ -54,22 +30,13 @@ class ChromeTestSuite : public base::TestSuite {
browser_dir_ = browser_dir;
}
- // Client for embedding content in Chrome.
- chrome::ChromeContentClient chrome_content_client_;
- chrome::ChromeContentBrowserClient chrome_browser_content_client_;
-
- base::StatsTable* stats_table_;
-
- // The name used for the stats file so it can be cleaned up on posix during
- // test shutdown.
- std::string stats_filename_;
-
// Alternative path to browser binaries.
FilePath browser_dir_;
+ std::string stats_filename_;
+ scoped_ptr<base::StatsTable> stats_table_;
+
ScopedOleInitializer ole_initializer_;
- scoped_refptr<LocalHostResolverProc> host_resolver_proc_;
- net::ScopedDefaultHostResolverProc scoped_host_resolver_proc_;
};
#endif // CHROME_TEST_BASE_CHROME_TEST_SUITE_H_

Powered by Google App Engine
This is Rietveld 408576698