chrome/browser/safe_browsing/client_side_detection_service_unittest.cc - Issue 7744039: Switch ChromeTestSuite to the same convention as ContentTestSuite:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

Issue 7744039: Switch ChromeTestSuite to the same convention as ContentTestSuite: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more fixing Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/web_cache_manager_unittest.cc ('k') | chrome/browser/search_engines/template_url_parser_unittest.cc » ('j') | chrome/test/base/chrome_test_suite.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

diff --git a/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc b/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

index dcf2076c6e5def5700a288cf8c44074219a5e7e3..83ce5aa7ea41113d793c17656832c3e987997986 100644

--- a/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

+++ b/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

@@ -18,7 +18,6 @@

#include "chrome/common/safe_browsing/client_model.pb.h"

#include "chrome/common/safe_browsing/csd.pb.h"

#include "chrome/renderer/safe_browsing/features.h"

-#include "chrome/test/base/testing_browser_process_test.h"

#include "content/browser/browser_thread.h"

#include "content/common/url_fetcher.h"

#include "content/test/test_url_fetcher_factory.h"

@@ -63,7 +62,7 @@ ACTION(QuitCurrentMessageLoop) {

} // namespace

-class ClientSideDetectionServiceTest : public TestingBrowserProcessTest {

+class ClientSideDetectionServiceTest : public testing::Test {

protected:

virtual void SetUp() {

file_thread_.reset(new BrowserThread(BrowserThread::FILE, &msg_loop_));