content/browser/DEPS - Issue 7744039: Switch ChromeTestSuite to the same convention as ContentTestSuite:

Side by Side Diff: content/browser/DEPS

Issue 7744039: Switch ChromeTestSuite to the same convention as ContentTestSuite: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more fixing Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+content/gpu", # For gpu_info_collector.h and in-process GPU	2 "+content/gpu", # For gpu_info_collector.h and in-process GPU

3	3

4 # DO NOT ADD ANY CHROME INCLUDES HERE!!!	4 # DO NOT ADD ANY CHROME INCLUDES HERE!!!

5 # See https://sites.google.com/a/chromium.org/dev/developers/content-module	5 # See https://sites.google.com/a/chromium.org/dev/developers/content-module

6 # for more information.	6 # for more information.

7	7

8 # ONLY USED BY TESTS	8 # ONLY USED BY TESTS

	9 "+chrome/browser/browser_process.h",
	jam 2011/08/27 18:01:31 Pawel: we really need to get this out of here very Pawel: we really need to get this out of here very soon, otherwise non-test code will use it. ui/browser.h was kind of ok because if non-test code used it, they would most likely have to include other chrome code and we'd catch them this way. but now non-test code can use browser_process.h to grab content objects and we won't be able to catch this. jam 2011/08/27 18:03:32 btw looking at your change, it's not clear to me w Show quoted text On 2011/08/27 18:01:31, John Abd-El-Malek wrote: > Pawel: we really need to get this out of here very soon, otherwise non-test code > will use it. ui/browser.h was kind of ok because if non-test code used it, they > would most likely have to include other chrome code and we'd catch them this > way. but now non-test code can use browser_process.h to grab content objects and > we won't be able to catch this. btw looking at your change, it's not clear to me why it it was even necessary to add this? none of the changed files in content added this include Paweł Hajdan Jr. 2011/08/29 16:46:23 I'm working on it right now. This was blocking man Show quoted text On 2011/08/27 18:01:31, John Abd-El-Malek wrote: > Pawel: we really need to get this out of here very soon, otherwise non-test code > will use it. ui/browser.h was kind of ok because if non-test code used it, they > would most likely have to include other chrome code and we'd catch them this > way. but now non-test code can use browser_process.h to grab content objects and > we won't be able to catch this. I'm working on it right now. This was blocking many moves from unit_tests to content_unittests, and now I might even be able to do the content_unittests transition completely. This DEPS problem should be resolved today. jam 2011/08/29 16:51:21 great, thanks :) Show quoted text On 2011/08/29 16:46:23, Paweł Hajdan Jr. wrote: > On 2011/08/27 18:01:31, John Abd-El-Malek wrote: > > Pawel: we really need to get this out of here very soon, otherwise non-test > code > > will use it. ui/browser.h was kind of ok because if non-test code used it, > they > > would most likely have to include other chrome code and we'd catch them this > > way. but now non-test code can use browser_process.h to grab content objects > and > > we won't be able to catch this. > > I'm working on it right now. This was blocking many moves from unit_tests to > content_unittests, and now I might even be able to do the content_unittests > transition completely. This DEPS problem should be resolved today. great, thanks :)
9 "+chrome/browser/ui/browser.h",	10 "+chrome/browser/ui/browser.h",

10 ]	11 ]

OLD	NEW

« chrome/test/base/chrome_test_suite.cc ('K') | « chrome/test/ui/ui_test_suite.cc ('k') | content/browser/debugger/devtools_manager_unittest.cc » ('j') | no next file with comments »