Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 7744038: Update breakpad to r826 (Closed)

Created:
9 years, 4 months ago by Mark Mentovai
Modified:
9 years, 4 months ago
CC:
chromium-reviews, Robert Sesek, Nico
Visibility:
Public.

Description

Update breakpad to r826 to pick up: ------------------------------------------------------------------------ r826 | mark@chromium.org | 2011-08-25 17:19:29 -0400 (Thu, 25 Aug 2011) | 14 lines Fix CalculateStackSize to behave properly when the main thread's stack is split up into multiple regions. An older workaround relyied on known fixed stack locations and only filled in the initial page of the stack if it was in a distinct region. The new approach looks upwards for additional regions that appear to be part of the same stack. With PIE on Lion, the stack no longer begins at a fixed address, so the older workaround became ineffective. BUG=247, chromium:94107 TEST=Stacks should run through to _main/start and then stop when examining Chrome on Lion with PIE and "slid" stacks. Review URL: http://breakpad.appspot.com/300001 ------------------------------------------------------------------------ BUG=94107 TEST=Stacks should run through to _main/start and then stop when examining Chrome on Lion with PIE and "slid" stacks. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98304

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
TBR (DEPS)
9 years, 4 months ago (2011-08-25 21:22:42 UTC) #1
Scott Hess - ex-Googler
9 years, 4 months ago (2011-08-25 21:28:20 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698