functional/passwords.py - Issue 7744035: To fix the failing password test: passwords.PasswordTest.testDisplayAndSavePasswordInfobar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: functional/passwords.py

Issue 7744035: To fix the failing password test: passwords.PasswordTest.testDisplayAndSavePasswordInfobar (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/test/

Patch Set: '' Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: functional/passwords.py

===================================================================

--- functional/passwords.py (revision 98727)

+++ functional/passwords.py (working copy)

@@ -102,9 +102,10 @@

self.PerformActionOnInfobar('accept', infobar_index=0)

self.NavigateToURL(url_logout)

self.AppendTab(pyauto.GURL(url_https)) # New tab to avoid bug 70694

- # Wait until accounts page load to detect value in username field.

- self.WaitUntil(lambda: self.GetDOMValue('document.readyState', 0, 1),

- expect_retval='complete')

+ # Wait until username is filled by the Password manager on the login page.

+ self.assertTrue(self.WaitUntil(

+ lambda: self.GetDOMValue('document.getElementById("Email").value',

+ 0, 0) != ""))

Nirnimesh 2011/08/31 08:16:41 use '

Venkat Yellapu 2011/09/01 00:32:56 Done.

test_utils.VerifyGoogleAccountCredsFilled(self, username, password,

tab_index=1, windex=0)

self.ExecuteJavascript('document.getElementById("gaia_loginform").submit();'

« no previous file with comments | « functional/PYAUTO_TESTS ('k') | no next file » | no next file with comments »