Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: tests/local_rietveld.py

Issue 7744030: Make GAE instance bind all interfaces when a variable is set. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/local_rietveld.py
diff --git a/tests/local_rietveld.py b/tests/local_rietveld.py
index 49d1536f5865b12e7fab1cb3f73fa3d38d3c2393..d9727f1dd8131c1a68b84f6bf590ca6e879e84a6 100755
--- a/tests/local_rietveld.py
+++ b/tests/local_rietveld.py
@@ -96,6 +96,14 @@ class LocalRietveld(object):
'--port=%d' % self.port,
'--datastore_path=' + os.path.join(self.rietveld, 'tmp.db'),
'-c']
+
+ # CHEAP TRICK
+ # By default you only want to bind on loopback but I'm testing over a
+ # headless computer so it's useful to be able to access the test instance
+ # remotely.
+ if os.environ.get('GAE_LISTEN_ALL', '') == 'true':
+ cmd.extend(('-a', '0.0.0.0'))
+
self.test_server = subprocess2.Popen(
cmd, stdout=pipe, stderr=pipe, cwd=self.rietveld)
# Loop until port 127.0.0.1:port opens or the process dies.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698