Centralize code for freeing LargeObjectChunks, fixing an uncommit bug.

Centralize code for freeing LargeObjectChunks, fixing an uncommit bug.

Due to heavy copy-n-paste, the handling of guard pages was inconsistent and we
didn't uncommit exactly the region we previously committed. Furthermore, the LOG
calls weren't consistent, either.
Committed: http://code.google.com/p/v8/source/detail?r=9021

[Vyacheslav Egorov (Chromium), 2011-08-25 15:22:54]

LGTM

Nice catch!

http://codereview.chromium.org/7744025/diff/1/src/spaces.cc
File src/spaces.cc (right):

http://codereview.chromium.org/7744025/diff/1/src/spaces.cc#newcode2779
src/spaces.cc:2779: Setup();
Calling Setup from TearDown is very confusing.

[Sven Panne, 2011-08-26 07:47:25]

On 2011/08/25 15:22:54, Vyacheslav Egorov wrote:
> LGTM
> 
> Nice catch!
> 
> http://codereview.chromium.org/7744025/diff/1/src/spaces.cc
> File src/spaces.cc (right):
> 
> http://codereview.chromium.org/7744025/diff/1/src/spaces.cc#newcode2779
> src/spaces.cc:2779: Setup();
> Calling Setup from TearDown is very confusing.

I thought so, too, but renaming it to something like "Reset" or "Clear" makes
its call in Heap::Setup confusing. :-} But the latter call really change
anything at all, so in its current state it's superfluous. But with the upcoming
GC merge, I don't think there is an urgent need for cosmetic changes in this
area...