Add missing entry for new content type 'auto-select-certificate' in content_settings_handler

Add missing entry for new content type 'auto-select-certificate' to kContentSettingsTypeGroupNames array of the content_settings_handler.

Fixes chrome crashing when opening an incognito window while the preferences tab is open.


BUG=81825
TEST=chrome not crashing


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98283

[markusheintz_, 2011-08-24 23:36:57]

Please review this CL. Thanks a lot.

[battre, 2011-08-25 08:15:49]

LGTM

http://codereview.chromium.org/7744007/diff/1/chrome/browser/ui/webui/options...
File chrome/browser/ui/webui/options/content_settings_handler.cc (right):

http://codereview.chromium.org/7744007/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/content_settings_handler.cc:64:
{CONTENT_SETTINGS_TYPE_AUTO_SELECT_CERTIFICATE, "auto-select-certificate"},
This does not show up in content_settings_types.h in codesearch (yet)?!? Is
codesearch out of sync or did you miss to add something?

http://codereview.chromium.org/7744007/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/content_settings_handler.cc:65: };
Does it make sense to add
COMPILE_ASSERT(arraysize(kContentSettingsTypeGroupNames) ==
ContentSettingsType::CONTENT_SETTINGS_NUM_TYPES, MISSING_CONTENT_SETTINGS_TYPE);
here?

[markusheintz_, 2011-08-25 14:39:51]

http://codereview.chromium.org/7744007/diff/1/chrome/browser/ui/webui/options...
File chrome/browser/ui/webui/options/content_settings_handler.cc (right):

http://codereview.chromium.org/7744007/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/content_settings_handler.cc:64:
{CONTENT_SETTINGS_TYPE_AUTO_SELECT_CERTIFICATE, "auto-select-certificate"},
On 2011/08/25 08:15:49, battre wrote:
> This does not show up in content_settings_types.h in codesearch (yet)?!? Is
> codesearch out of sync or did you miss to add something?

No. The content type is there if you check the code on trunk.

http://codereview.chromium.org/7744007/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/content_settings_handler.cc:65: };
On 2011/08/25 08:15:49, battre wrote:
> Does it make sense to add
> COMPILE_ASSERT(arraysize(kContentSettingsTypeGroupNames) ==
> ContentSettingsType::CONTENT_SETTINGS_NUM_TYPES,
MISSING_CONTENT_SETTINGS_TYPE);
> here?

Absolutely!! Done

[commit-bot: I haz the power, 2011-08-25 20:17:42]

Change committed as 98283