Issue 7744004: Avoid long test_server timeouts by using action_timeout_ms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7744004: Avoid long test_server timeouts by using action_timeout_ms (Closed)

Created:
9 years, 4 months ago by Paweł Hajdan Jr.

Modified:
9 years, 3 months ago

Reviewers:
Mark Mentovai, wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Avoid long test_server timeouts by using action_timeout_ms instead of action_max_timeout_ms. This increases action_timeout_ms a little bit, otherwise test_server becomes more flaky (fails to start in time). This effectively reduces the timeout for TestServer start from 45s to 10s. BUG=93770 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100706

Patch Set 1 #

Patch Set 2 : should work now #

Patch Set 3 : rebase #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -11 lines)			Patch
M	base/test/test_timeouts.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_test.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/test/test_server.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	net/test/test_server_posix.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/test/test_server_win.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

Please review: Mark: base (OWNERS) Wan-Teh: net

9 years, 4 months ago (2011-08-24 22:48:35 UTC) #1

wtc

9 years, 4 months ago (2011-08-24 23:43:52 UTC) #2

LGTM.

It would be nice to summarize in the CL's commit message
that you reduced the timeout for the test server to start
from 45 to 10 seconds.

Expand Messages | Collapse Messages