Issue 7743006: Remove unused test command-line switches.

Issue 7743006: Remove unused test command-line switches. (Closed)

Created:
9 years, 4 months ago by Paweł Hajdan Jr.

Modified:
9 years, 4 months ago

Reviewers:
brettw, Timur Iskhodzhanov, Jay Civelli

CC:
chromium-reviews, Alexander Potapenko, brettw-cc_chromium.org, Timur Iskhodzhanov, pam+watch_chromium.org, Paweł Hajdan Jr., stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove unused test command-line switches. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98263

Patch Set 2 : cleanup #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -22 lines)			Patch
M	base/test/test_switches.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	base/test/test_switches.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	base/test/test_timeouts.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/test/base/out_of_proc_test_runner.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	tools/valgrind/chrome_tests.py	View	1	2 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

Please review (OWNERS): Brett: base Jay: chrome Timur: valgrind

9 years, 4 months ago (2011-08-25 00:49:23 UTC) #1

Timur Iskhodzhanov

Valgrind part. http://codereview.chromium.org/7743006/diff/1/tools/valgrind/chrome_tests.py File tools/valgrind/chrome_tests.py (right): http://codereview.chromium.org/7743006/diff/1/tools/valgrind/chrome_tests.py#newcode278 tools/valgrind/chrome_tests.py:278: "--ui-test-action-max-timeout=280000"] Am I right that --ui-test-action-max-timeout value ...

9 years, 4 months ago (2011-08-25 08:21:56 UTC) #2

Paweł Hajdan Jr.

http://codereview.chromium.org/7743006/diff/1/tools/valgrind/chrome_tests.py File tools/valgrind/chrome_tests.py (right): http://codereview.chromium.org/7743006/diff/1/tools/valgrind/chrome_tests.py#newcode278 tools/valgrind/chrome_tests.py:278: "--ui-test-action-max-timeout=280000"] On 2011/08/25 08:21:56, Timur Iskhodzhanov wrote: > Am ...

9 years, 4 months ago (2011-08-25 17:33:13 UTC) #5

Timur Iskhodzhanov

9 years, 4 months ago (2011-08-25 17:35:06 UTC) #6

LGTM
Thanks for decreasing the size of the Valgrind invocation cmdline :)

Expand Messages | Collapse Messages