Issue 7743004: Move extension/webstore-related URL getters to the extension_urls namespace.

Issue 7743004: Move extension/webstore-related URL getters to the extension_urls namespace. (Closed)

Created:
9 years, 4 months ago by Mihai Parparita -not on Chrome

Modified:
9 years, 4 months ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews, Erik does not do reviews, brettw-cc_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr., estade+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Move extension/webstore-related URL getters to the extension_urls namespace. R=asargent@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98156

Patch Set 2 : Review feedback. #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -75 lines)			Patch
M	chrome/browser/extensions/extension_tab_helper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_updater.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_updater_unittest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_webstore_private_api.cc	View		3 chunks	+3 lines, -11 lines	0 comments	Download
M	chrome/browser/extensions/extensions_ui.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/ntp_resource_cache.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/extension.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View		6 chunks	+8 lines, -24 lines	0 comments	Download
M	chrome/common/extensions/extension_constants.h	View	1	3 chunks	+24 lines, -13 lines	0 comments	Download
M	chrome/common/extensions/extension_constants.cc	View		3 chunks	+45 lines, -14 lines	0 comments	Download
M	chrome/renderer/extensions/chrome_webstore_bindings.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

asargent_no_longer_on_chrome

LGTM http://codereview.chromium.org/7743004/diff/1/chrome/common/extensions/extension_constants.h File chrome/common/extensions/extension_constants.h (right): http://codereview.chromium.org/7743004/diff/1/chrome/common/extensions/extension_constants.h#newcode284 chrome/common/extensions/extension_constants.h:284: // Return the update URL used by gallery/webstore ...

9 years, 4 months ago (2011-08-25 00:05:09 UTC) #2

Mihai Parparita -not on Chrome

9 years, 4 months ago (2011-08-25 00:46:29 UTC) #3

http://codereview.chromium.org/7743004/diff/1/chrome/common/extensions/extens...
File chrome/common/extensions/extension_constants.h (right):

http://codereview.chromium.org/7743004/diff/1/chrome/common/extensions/extens...
chrome/common/extensions/extension_constants.h:284: // Return the update URL
used by gallery/webstore extensions/apps.
On 2011/08/25 00:05:09, Antony Sargent wrote:
> Can you add a note to this comment that |secure| might be ignored if
> --apps-gallery-update-url is passed on the command line?

Done.

Expand Messages | Collapse Messages