Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 7741042: Make (some) functions called from builtin functions use the callback's global as receiver. (Closed)

Created:
9 years, 4 months ago by Lasse Reichstein
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make (some) functions called from builtin functions use the callback's global as receiver. Changes GetGlobalReceiver() to GetDefaultReceiver(func) that returns undefined for strict and native functions, and the function's context's global proxy for "normal" functions. BUG=v8:1547 TEST=cctest/api-test/ForeignFunctionReceiver Committed: http://code.google.com/p/v8/source/detail?r=9030

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -151 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M src/array.js View 1 chunk +1 line, -2 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M src/runtime.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/runtime.cc View 1 chunk +12 lines, -3 lines 0 comments Download
M src/string.js View 3 chunks +3 lines, -6 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +104 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
9 years, 4 months ago (2011-08-26 13:24:27 UTC) #1
Vyacheslav Egorov (Chromium)
9 years, 4 months ago (2011-08-26 13:32:42 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698