Issue 7741038: Fix a memory leak in the IME candidate window of Chrome OS (2nd try).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7741038: Fix a memory leak in the IME candidate window of Chrome OS (2nd try). (Closed)

Created:
9 years, 4 months ago by kinaba

Modified:
9 years, 3 months ago

Reviewers:
Yusuke Sato

CC:
chromium-reviews, davemoore+watch_chromium.org, horo1

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix a memory leak in the IME candidate window of Chrome OS (2nd try). TEST=Observed the leak and its remediation by inserting debug counter for CandidateView constructor/destructor. Verified no crash to happen by (1.Focus Omnibox 2.Enable Japanese IME 3.type "henkan" and press space key two times 4.press enter 5.type "a"). BUG=chromium-os:18893 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98931

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/browser/chromeos/input_method/candidate_window.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kinaba

The previous patch http://codereview.chromium.org/7624039/ deleted too early (and caused crashes after the candidate window is ...

9 years, 4 months ago (2011-08-26 00:56:30 UTC) #1

Yusuke Sato

9 years, 4 months ago (2011-08-26 06:16:35 UTC) #2

On 2011/08/26 00:56:30, kinaba wrote:
> The previous patch http://codereview.chromium.org/7624039/ deleted too early
> (and caused crashes after the candidate window is closed by commit of a
> candidate). The current one copied the idiom commonly used throughout
Chromium.

LGTM, thanks!

nit: write something in TEST= line.

Expand Messages | Collapse Messages