chrome/browser/extensions/extension_webstore_private_apitest.cc - Issue 7741037: Add WebstoreInlineInstaller (downloads store data, shows the install UI, and starts the install).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_webstore_private_apitest.cc

Issue 7741037: Add WebstoreInlineInstaller (downloads store data, shows the install UI, and starts the install). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Put webstore response in the right directory. Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_webstore_private_api.cc ('k') | chrome/browser/extensions/webstore_inline_install_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_webstore_private_apitest.cc

diff --git a/chrome/browser/extensions/extension_webstore_private_apitest.cc b/chrome/browser/extensions/extension_webstore_private_apitest.cc

index 52fe4883ab5f2a36c2d64b451f615e485fba8416..90b76b2431377a8b65e8ef34d87e375123313d8d 100644

--- a/chrome/browser/extensions/extension_webstore_private_apitest.cc

+++ b/chrome/browser/extensions/extension_webstore_private_apitest.cc

@@ -4,6 +4,7 @@

#include "base/stringprintf.h"

#include "chrome/browser/extensions/extension_apitest.h"

+#include "chrome/browser/extensions/extension_install_dialog.h"

#include "chrome/browser/extensions/extension_install_ui.h"

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/extension_webstore_private_api.h"

@@ -32,7 +33,7 @@ class ExtensionWebstorePrivateApiTest : public ExtensionApiTest {

host_resolver()->AddRule("www.example.com", "127.0.0.1");

ASSERT_TRUE(test_server()->Start());

BeginInstallWithManifestFunction::SetIgnoreUserGestureForTests(true);

- BeginInstallWithManifestFunction::SetAutoConfirmForTests(true);

+ SetExtensionInstallDialogForManifestAutoConfirmForTests(true);

ExtensionInstallUI::DisableFailureUIForTests();

}

@@ -80,7 +81,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebstorePrivateApiTest, InstallLocalized) {

// Now test the case where the user cancels the confirmation dialog.

IN_PROC_BROWSER_TEST_F(ExtensionWebstorePrivateApiTest, InstallCancelled) {

- BeginInstallWithManifestFunction::SetAutoConfirmForTests(false);

+ SetExtensionInstallDialogForManifestAutoConfirmForTests(false);

ASSERT_TRUE(RunInstallTest("cancelled.html", "extension.crx"));

}