Issue 7741036: NaCl PPAPI Proxy: wrap up with crash detection. Clean-up handling code to skip remote shutdown ca...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7741036: NaCl PPAPI Proxy: wrap up with crash detection. Clean-up handling code to skip remote shutdown ca... (Closed)

Created:
9 years, 4 months ago by polina

Modified:
9 years, 4 months ago

Reviewers:
Nick Bray, sehr (please use chromium)

CC:
chromium-reviews, dmichael (off chromium)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

NaCl PPAPI Proxy: wrap up with crash detection. Clean-up handling code to skip remote shutdown calls when the nexe is known to be dead. Add a test for crashing on other than the main thread, which depending on thread timing might happen when the main thread is servicing a PPP call or waiting for the next one. Add another test that will fail on a CHECK for an unsupported Pepper call off the main thread. BUG= http://code.google.com/p/nativeclient/issues/detail?id=1780, http://code.google.com/p/nativeclient/issues/detail?id=2105, http://code.google.com/p/nativeclient/issues/detail?id=1682 TEST=scons run_ppapi_crash_browser_test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98507

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+158 lines, -23 lines)			Patch
M	ppapi/native_client/src/shared/ppapi_proxy/browser_globals.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/browser_ppp.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/browser_ppp.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/plugin_ppp_messaging_rpc_server.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/plugin.cc	View		4 chunks	+10 lines, -5 lines	0 comments	Download
M	ppapi/native_client/tests/ppapi_browser/crash/nacl.scons	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	ppapi/native_client/tests/ppapi_browser/crash/ppapi_crash.html	View	1 2	2 chunks	+31 lines, -10 lines	0 comments	Download
A	ppapi/native_client/tests/ppapi_browser/crash/ppapi_crash_off_main_thread.cc	View		1 chunk	+48 lines, -0 lines	0 comments	Download
A	ppapi/native_client/tests/ppapi_browser/crash/ppapi_crash_off_main_thread.nmf	View		1 chunk	+7 lines, -0 lines	0 comments	Download
A	ppapi/native_client/tests/ppapi_browser/crash/ppapi_crash_ppapi_off_main_thread.cc	View		1 chunk	+40 lines, -0 lines	0 comments	Download
A	ppapi/native_client/tests/ppapi_browser/crash/ppapi_crash_ppapi_off_main_thread.nmf	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

sehr (please use chromium)

9 years, 4 months ago (2011-08-26 20:33:37 UTC) #2

On 2011/08/25 23:59:39, polina wrote:

LGTM.