Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 7741035: Fix missing null check in Clipboard::ReadImage. (Closed)

Created:
9 years, 3 months ago by dcheng
Modified:
9 years, 3 months ago
Reviewers:
tony
CC:
chromium-reviews
Visibility:
Public.

Description

Fix missing null check in Clipboard::ReadImage. Even though CF_DIB is always supposed to be synthesized from CF_BITMAP, change the types to match in Clipboard::ReadAvailableTypes. We also add a NULL check in Clipboard::ReadImage in case the contents of the clipboard change between the time the clipboard types are accessed and the the clipboard content is accessed. BUG=94332 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98361

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ui/base/clipboard/clipboard_win.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
dcheng
I lost the null check when I was refactoring things to fix the other bug.
9 years, 3 months ago (2011-08-25 23:48:00 UTC) #1
tony
9 years, 3 months ago (2011-08-25 23:59:39 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698