Issue 7741032: Upstream android i18n change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7741032: Upstream android i18n change (Closed)

Created:
9 years, 4 months ago by michaelbai

Modified:
9 years, 3 months ago

Reviewers:
brettw

CC:
chromium-reviews, brettw-cc_chromium.org, jshin+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Upstream android i18n change BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98638

Patch Set 2 : address comments #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	base/i18n/number_formatting_unittest.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	base/i18n/rtl.cc	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brettw

http://codereview.chromium.org/7741032/diff/1/base/i18n/rtl.cc File base/i18n/rtl.cc (right): http://codereview.chromium.org/7741032/diff/1/base/i18n/rtl.cc#newcode261 base/i18n/rtl.cc:261: text->insert(static_cast<std::wstring::size_type>(0), 1, Why use static_cast here and 0U above? ...

9 years, 4 months ago (2011-08-26 19:28:52 UTC) #2

michaelbai

9 years, 4 months ago (2011-08-26 22:01:49 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 7741032: Upstream android i18n change (Closed)

Description

Patch Set 1 #

Patch Set 2 : address comments #

Messages