Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 7741026: clang: add an option to update.sh to pull lldb as well (Closed)

Created:
9 years, 4 months ago by Evan Martin
Modified:
9 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews, fischman+watch_chromium.org, pam+watch_chromium.org, ukai+watch_chromium.org
Visibility:
Public.

Description

clang: add an option to update.sh to pull lldb as well Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99235

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M tools/clang/scripts/update.sh View 3 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Evan Martin
9 years, 4 months ago (2011-08-25 19:03:05 UTC) #1
Nico
lgtm
9 years, 4 months ago (2011-08-25 23:01:38 UTC) #2
Nico
(after syncing, you will probably want to skip the "download clang binaries" step if lldb ...
9 years, 4 months ago (2011-08-26 13:25:40 UTC) #3
Nico
Do you want to land this? I'm kinda waiting on the cmdline flag bits for ...
9 years, 3 months ago (2011-09-01 19:55:34 UTC) #4
Evan Martin
On 2011/09/01 19:55:34, Nico wrote: > Do you want to land this? I'm kinda waiting ...
9 years, 3 months ago (2011-09-01 20:15:50 UTC) #5
Nico
On Thu, Sep 1, 2011 at 1:15 PM, <evan@chromium.org> wrote: > On 2011/09/01 19:55:34, Nico ...
9 years, 3 months ago (2011-09-01 20:17:19 UTC) #6
Evan Martin
9 years, 3 months ago (2011-09-01 20:21:31 UTC) #7
On Thu, Sep 1, 2011 at 1:17 PM, Nico Weber <thakis@chromium.org> wrote:
> On Thu, Sep 1, 2011 at 1:15 PM,  <evan@chromium.org> wrote:
>> On 2011/09/01 19:55:34, Nico wrote:
>>>
>>> Do you want to land this? I'm kinda waiting on the cmdline flag bits for
>>> something else. (If not, I can just copy them into my CL, but I didn't
>>> want to
>>> give you merge conflicts)
>>
>> OK, sure.  I didn't land it because it turns out lldb doesn't build on
>> Linux,
>> but in principle this is correct and maybe it works on Mac.
>
> Hmyeah, but on mac you need to do weird certificate munging etc. (And
> on Lion, lldb is in /Developer/usr/bin anyway.) If it doesn't work on
> linux, let's not land it.

Too late!  :P
Since it's off by default, caveat emptor on using the flag...

Powered by Google App Engine
This is Rietveld 408576698