Put archive file handling support behind a flag for M14.

Put archive file handling support behind a flag for M14.

BUG=chromium-os:19657
TEST=make sure 'Open archive' task shows up only when --enable-archives switch is provided
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98360

[rginda, 2011-08-25 20:14:37]

On 2011/08/25 17:11:43, zel wrote:

We disable the image editor with some special case code in file_manager.js, in
order to avoid making multiple manifests.  Check out IMAGE_EDITOR_ENABLED in
file_manager.js.  The only catch is that we don't surface chrome flags to the
UI, though I've seen other extensions hack it by adding a fake string to the
hash returned by the getStrings method of the private extension api.

Considering the time frame and temporary-ness of this, I'm ok with landing it
now, but please add a TODO comment somewhere about how it needs to be removed,
and a key/value to manifest.json that there is another manifest that needs to be
kept in sync.

[zel, 2011-08-25 20:37:39]

PTAL

I've flipped flag handling to getString(), less bloating of the binary if
nothing else...


On Thu, Aug 25, 2011 at 1:14 PM, <rginda@chromium.org> wrote:

> On 2011/08/25 17:11:43, zel wrote:
>
> We disable the image editor with some special case code in file_manager.js,
> in
> order to avoid making multiple manifests.  Check out IMAGE_EDITOR_ENABLED
> in
> file_manager.js.  The only catch is that we don't surface chrome flags to
> the
> UI, though I've seen other extensions hack it by adding a fake string to
> the
> hash returned by the getStrings method of the private extension api.
>
> Considering the time frame and temporary-ness of this, I'm ok with landing
> it
> now, but please add a TODO comment somewhere about how it needs to be
> removed,
> and a key/value to manifest.json that there is another manifest that needs
> to be
> kept in sync.
>
>
>
http://codereview.chromium.**org/7741020/<http://codereview.chromium.org/7741...
>

[rginda, 2011-08-25 20:39:39]

LGTM without the grd change.

http://codereview.chromium.org/7741020/diff/4002/chrome/browser/browser_resou...
File chrome/browser/browser_resources.grd (right):

http://codereview.chromium.org/7741020/diff/4002/chrome/browser/browser_resou...
chrome/browser/browser_resources.grd:150: <include
name="IDR_FILEMANAGER_NOARCHIVE_MANIFEST"
file="resources\file_manager\manifest_noarchive.json" type="BINDATA" />
This is no longer needed.

[zel, 2011-08-25 20:51:36]

http://codereview.chromium.org/7741020/diff/4002/chrome/browser/browser_resou...
File chrome/browser/browser_resources.grd (right):

http://codereview.chromium.org/7741020/diff/4002/chrome/browser/browser_resou...
chrome/browser/browser_resources.grd:150: <include
name="IDR_FILEMANAGER_NOARCHIVE_MANIFEST"
file="resources\file_manager\manifest_noarchive.json" type="BINDATA" />
On 2011/08/25 20:39:39, rginda wrote:
> This is no longer needed.

Done.