Issue 7741019: Move SafeBeginInstallHelper to be a top-level class (WebstoreInstallHelper).

Issue 7741019: Move SafeBeginInstallHelper to be a top-level class (WebstoreInstallHelper). (Closed)

Created:
9 years, 4 months ago by Mihai Parparita -not on Chrome

Modified:
9 years, 4 months ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Move SafeBeginInstallHelper to be a top-level class (WebstoreInstallHelper). R=asargent@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98272

Patch Set 2 : Review feedback #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+342 lines, -234 lines)			Patch
M	chrome/browser/extensions/extension_webstore_private_api.h	View		3 chunks	+12 lines, -10 lines	0 comments	Download
M	chrome/browser/extensions/extension_webstore_private_api.cc	View	1	10 chunks	+27 lines, -224 lines	0 comments	Download
A	chrome/browser/extensions/webstore_install_helper.h	View	1	1 chunk	+115 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/webstore_install_helper.cc	View		1 chunk	+186 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

asargent_no_longer_on_chrome

LGTM http://codereview.chromium.org/7741019/diff/1/chrome/browser/extensions/extension_webstore_private_api.cc File chrome/browser/extensions/extension_webstore_private_api.cc (right): http://codereview.chromium.org/7741019/diff/1/chrome/browser/extensions/extension_webstore_private_api.cc#newcode32 chrome/browser/extensions/extension_webstore_private_api.cc:32: #include "content/common/url_fetcher.h" nit: remove url_fetcher.h include http://codereview.chromium.org/7741019/diff/1/chrome/browser/extensions/extension_webstore_private_api.cc#newcode35 chrome/browser/extensions/extension_webstore_private_api.cc:35: ...

9 years, 4 months ago (2011-08-25 17:57:02 UTC) #2

Mihai Parparita -not on Chrome

9 years, 4 months ago (2011-08-25 18:12:09 UTC) #3

http://codereview.chromium.org/7741019/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_webstore_private_api.cc (right):

http://codereview.chromium.org/7741019/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_webstore_private_api.cc:32: #include
"content/common/url_fetcher.h"
On 2011/08/25 17:57:02, Antony Sargent wrote:
> nit: remove url_fetcher.h include

Done.

http://codereview.chromium.org/7741019/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_webstore_private_api.cc:35: #include
"net/url_request/url_request_status.h"
On 2011/08/25 17:57:02, Antony Sargent wrote:
> nit: remove url_request_status.h include

Done.

http://codereview.chromium.org/7741019/diff/1/chrome/browser/extensions/webst...
File chrome/browser/extensions/webstore_install_helper.h (right):

http://codereview.chromium.org/7741019/diff/1/chrome/browser/extensions/webst...
chrome/browser/extensions/webstore_install_helper.h:50:
WebstoreInstallHelper(Delegate* delegate,
On 2011/08/25 17:57:02, Antony Sargent wrote:
> nit: include a comment here that only one of icon_data or icon_url can be
> specified, but it is legal for both to be empty

Done.

Expand Messages | Collapse Messages