Remove some unneeded reinterpret_casts

Remove some unneeded reinterpret_casts

BUG=None
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98417

[Denis Lagno, 2011-08-25 18:37:57]

please take a look

[willchan no longer on Chromium, 2011-08-25 18:40:02]

On vacation
On Aug 26, 2011 12:07 AM, <dilmah@chromium.org> wrote:
> Reviewers: willchan,
>
> Message:
> please take a look
>
> Description:
> Remove some unneeded reinterpret_casts
>
> BUG=None
> TEST=None
>
>
> Please review this at http://codereview.chromium.org/7741018/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
> M base/string16.cc
> M base/threading/thread_local.h
>
>
> Index: base/string16.cc
> diff --git a/base/string16.cc b/base/string16.cc
> index
>
6fc38ce7cb09c78ec71d2f60c4a0f4bd5bce5b4e..a801610fe4decc89deda1d966b86481a16af8399

> 100644
> --- a/base/string16.cc
> +++ b/base/string16.cc
> @@ -51,11 +51,11 @@ const char16* c16memchr(const char16* s, char16 c,
> size_t n) {
> }
>
> char16* c16memmove(char16* s1, const char16* s2, size_t n) {
> - return reinterpret_cast<char16*>(memmove(s1, s2, n * sizeof(char16)));
> + return static_cast<char16*>(memmove(s1, s2, n * sizeof(char16)));
> }
>
> char16* c16memcpy(char16* s1, const char16* s2, size_t n) {
> - return reinterpret_cast<char16*>(memcpy(s1, s2, n * sizeof(char16)));
> + return static_cast<char16*>(memcpy(s1, s2, n * sizeof(char16)));
> }
>
> char16* c16memset(char16* s, char16 c, size_t n) {
> Index: base/threading/thread_local.h
> diff --git a/base/threading/thread_local.h b/base/threading/thread_local.h
> index
>
3cdcb942e34072b0e8a940f500f4bd3fb3c6356d..79cf3c5b360b5c17e69ae6fa0b5d87d1e4b8e215

> 100644
> --- a/base/threading/thread_local.h
> +++ b/base/threading/thread_local.h
> @@ -114,7 +114,7 @@ class ThreadLocalBoolean {
> }
>
> void Set(bool val) {
> - tlp_.Set(reinterpret_cast<void*>(val ? 1 : 0));
> + tlp_.Set(val ? this : NULL);
> }
>
> private:
>
>

[Denis Lagno, 2011-08-25 18:49:33]

please take a look

[Evan Martin, 2011-08-25 18:56:54]

LGTM

Why are you doing this?

[Denis Lagno, 2011-08-25 20:13:36]

On 2011/08/25 18:56:54, Evan Martin wrote:
> Why are you doing this?

I develop some code => I need to study existing code => I read existing code =>
I notice suboptimal/dirty code => This code is in base/ and base/ should be
extra polished => I am fixing it.

[commit-bot: I haz the power, 2011-08-25 20:17:43]

Presubmit check for 7741018-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Found Singleton<T> in the following header files.
Please move them to an appropriate source file so that the template gets
instantiated in a single compilation unit.
  base/threading/thread_local.h

Presubmit checks took 2.6s to calculate.