Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 7741014: Fix mismatch about tabId in code and webrequest API documentation if requests don't belong to a tab (Closed)

Created:
9 years, 4 months ago by battre
Modified:
9 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Mike West
Visibility:
Public.

Description

Fix mismatch about tabId in code and webrequest API documentation if requests don't belong to a tab This CL updates the webrequest API documentation to state that requests that cannot be associated with a tab are labeled with "tabId = -1" instead of "tabId = null". I chose to update the documentation rather than the code for two reasons: - As 0 is a valid value for the tabId, we would need to distinguish between 0 and null. - For the RequestFilter type, 'tabId' is an optional parameter. I.e. we would need to distinguish between 0, null and undefined. BUG=93373 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/common/extensions/api/extension_api.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/experimental.webRequest.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
battre
Please review. Thanks.
9 years, 4 months ago (2011-08-25 09:32:21 UTC) #1
Matt Perry
LGTM
9 years, 4 months ago (2011-08-25 18:08:17 UTC) #2
commit-bot: I haz the power
9 years, 4 months ago (2011-08-25 20:32:16 UTC) #3
Change committed as 98289

Powered by Google App Engine
This is Rietveld 408576698