Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 7741007: Always enable the STATE_LOAD_SSL_HOST_INFO state to verify the crash fix (Closed)

Created:
9 years, 4 months ago by wtc
Modified:
9 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Always enable the STATE_LOAD_SSL_HOST_INFO state to verify the crash fix for bug 84426. But we will only use ssl_host_info_->state().certs if the cached info extension is enabled. Do not treat an empty ssl_host_info_->state().certs as failure because it is normal for us to not have the server's certificates if we have not visited the site before. R=agl@chromium.org BUG=84426 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98279

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M net/socket/ssl_client_socket_nss.cc View 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
wtc
9 years, 4 months ago (2011-08-25 02:00:35 UTC) #1
agl
LGTM. Do you intend to keep this on? There may be a performance impact of ...
9 years, 4 months ago (2011-08-25 14:01:26 UTC) #2
wtc
On 2011/08/25 14:01:26, agl wrote: > > Do you intend to keep this on? There ...
9 years, 3 months ago (2011-08-25 18:01:20 UTC) #3
commit-bot: I haz the power
9 years, 3 months ago (2011-08-25 20:13:53 UTC) #4
Change committed as 98279

Powered by Google App Engine
This is Rietveld 408576698