Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 7741002: Add code to keep track of what fraction of pageviews are top sites. (Closed)

Created:
9 years, 4 months ago by tburkard
Modified:
9 years, 4 months ago
Reviewers:
cbentzel, dominich
CC:
chromium-reviews, tburkard+watch_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, mmenke
Visibility:
Public.

Description

Add code to keep track of what fraction of pageviews are top sites. This code will be removed again once histograms have been collected (prior to the M15 branchpoint). R=cbentzel@chromium.org, dominich@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98250

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -3 lines) Patch
M chrome/browser/prerender/prerender_manager.h View 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 3 4 chunks +64 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_observer.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_observer.cc View 1 5 chunks +26 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tburkard
Ok trying this again hopefully this will not break the build this time :) The ...
9 years, 4 months ago (2011-08-24 23:21:48 UTC) #1
dominich
9 years, 4 months ago (2011-08-24 23:37:20 UTC) #2
LGTM++

again ;)

http://codereview.chromium.org/7741002/diff/1/chrome/browser/prerender/preren...
File chrome/browser/prerender/prerender_manager.cc (right):

http://codereview.chromium.org/7741002/diff/1/chrome/browser/prerender/preren...
chrome/browser/prerender/prerender_manager.cc:215: history::TopSites*
GetTopSites() const {
nit: is it worth caching the TopSites pointer instead of the Profile pointer?

Powered by Google App Engine
This is Rietveld 408576698