Issue 7741001: Add Aura support to views:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7741001: Add Aura support to views: (Closed)

Created:
9 years, 4 months ago by Ben Goodger (Google)

Modified:
9 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, Paweł Hajdan Jr., dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add Aura support to views: - change aura GYP_DEFINE to use_aura to be consistent with other switches - add gfx::NativeView/Window typedefs - add NativeWidgetAura/etc. - update some ifdefs and includes to build on windows. http://crbug.com/93944 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98234

Patch Set 1 : '' #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+592 lines, -37 lines)			Patch
M	build/common.gypi	View		7 chunks	+10 lines, -7 lines	0 comments	Download
M	ui/gfx/native_widget_types.h	View	1	7 chunks	+25 lines, -13 lines	0 comments	Download
M	views/controls/menu/menu_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	views/desktop/desktop_window_view.cc	View		2 chunks	+6 lines, -2 lines	0 comments	Download
A	views/events/event_aura.cc	View		1 chunk	+127 lines, -0 lines	0 comments	Download
M	views/focus/focus_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	views/native_types.h	View		2 chunks	+11 lines, -3 lines	0 comments	Download
M	views/views.gyp	View		4 chunks	+19 lines, -0 lines	0 comments	Download
M	views/widget/default_theme_provider.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
A	views/widget/native_widget_aura.h	View		1 chunk	+106 lines, -0 lines	0 comments	Download
A	views/widget/native_widget_aura.cc	View		1 chunk	+268 lines, -0 lines	0 comments	Download
M	views/widget/widget_unittest.cc	View		4 chunks	+12 lines, -4 lines	0 comments	Download
M	views/window/custom_frame_view.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	views/window/native_frame_view.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

9 years, 4 months ago (2011-08-24 22:29:34 UTC) #2

LGTM

http://codereview.chromium.org/7741001/diff/6003/ui/gfx/native_widget_types.h
File ui/gfx/native_widget_types.h (right):

http://codereview.chromium.org/7741001/diff/6003/ui/gfx/native_widget_types.h...
ui/gfx/native_widget_types.h:81: #if defined(USE_AURA)
Before class SkBitmap?

http://codereview.chromium.org/7741001/diff/6003/ui/gfx/native_widget_types.h...
ui/gfx/native_widget_types.h:165: // On Mac and Linux, a NativeView is a pointer
to an object, and is useless
Update comment.

Expand Messages | Collapse Messages