Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 7740083: Put pre- and auto-login behind flags. (Closed)

Created:
9 years, 3 months ago by Roger Tawa OOO till Jul 10th
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing), idana
Visibility:
Public.

Description

Put pre- and auto-login behind flags. Scott: please review the code under UI. Tim: please review the rest. BUG=None TEST=Make sure these feature are not enabled if the about:flags option is not set. Also make sure the option to enable auto-login is not visible in the Passwords section of the Personal Stuff section of the options page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99131

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -9 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/sync/signin_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/autologin_infobar_delegate.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/personal_options_handler.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Roger Tawa OOO till Jul 10th
9 years, 3 months ago (2011-08-31 17:12:12 UTC) #1
tim (not reviewing)
LGTM
9 years, 3 months ago (2011-08-31 20:06:20 UTC) #2
sky
LGTM
9 years, 3 months ago (2011-08-31 20:46:49 UTC) #3
commit-bot: I haz the power
9 years, 3 months ago (2011-09-01 05:17:09 UTC) #4
Change committed as 99131

Powered by Google App Engine
This is Rietveld 408576698