chrome/browser/autofill/autofill_manager_unittest.cc - Issue 7740070: Add metrics to measure time elapsed between form load and form submission with or without Autofill.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/autofill_manager_unittest.cc

Issue 7740070: Add metrics to measure time elapsed between form load and form submission with or without Autofill. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix compile Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/autofill_manager.cc ('K') | « chrome/browser/autofill/autofill_manager.cc ('k') | chrome/browser/autofill/autofill_metrics.h » ('j') | chrome/browser/autofill/autofill_metrics_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autofill/autofill_manager_unittest.cc

diff --git a/chrome/browser/autofill/autofill_manager_unittest.cc b/chrome/browser/autofill/autofill_manager_unittest.cc

index b850a4133817a8feb68d702d19ba0da0633a3577..7c7edeb5df2bc42ba59a6e18d04961ddf2c75fc9 100644

--- a/chrome/browser/autofill/autofill_manager_unittest.cc

+++ b/chrome/browser/autofill/autofill_manager_unittest.cc

@@ -516,7 +516,7 @@ class AutofillManagerTest : public TabContentsWrapperTestHarness {

}

void FormSubmitted(const FormData& form) {

- autofill_manager_->OnFormSubmitted(form);

+ autofill_manager_->OnFormSubmitted(form, 0);

jar (doing other things) 2011/08/31 17:02:21 Here again, I suspect rather than 0, you should su

Ilya Sherman 2011/08/31 21:56:23 This is actually just a filler value to make the c

}

void FillAutofillFormData(int query_id,