Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: chrome/renderer/autofill/form_autocomplete_browsertest.cc

Issue 7740070: Add metrics to measure time elapsed between form load and form submission with or without Autofill. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix compile Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/autofill_messages.h" 5 #include "chrome/common/autofill_messages.h"
6 #include "chrome/test/base/render_view_test.h" 6 #include "chrome/test/base/render_view_test.h"
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 #include "third_party/WebKit/Source/WebKit/chromium/public/WebDocument.h" 8 #include "third_party/WebKit/Source/WebKit/chromium/public/WebDocument.h"
9 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFormElement.h" 9 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFormElement.h"
10 #include "third_party/WebKit/Source/WebKit/chromium/public/WebString.h" 10 #include "third_party/WebKit/Source/WebKit/chromium/public/WebString.h"
(...skipping 17 matching lines...) Expand all
28 "<input name='lname' value='Deckard'/></form></html>"); 28 "<input name='lname' value='Deckard'/></form></html>");
29 29
30 // Submit the form. 30 // Submit the form.
31 ExecuteJavaScript("document.getElementById('myForm').submit();"); 31 ExecuteJavaScript("document.getElementById('myForm').submit();");
32 ProcessPendingMessages(); 32 ProcessPendingMessages();
33 33
34 const IPC::Message* message = render_thread_.sink().GetFirstMessageMatching( 34 const IPC::Message* message = render_thread_.sink().GetFirstMessageMatching(
35 AutofillHostMsg_FormSubmitted::ID); 35 AutofillHostMsg_FormSubmitted::ID);
36 ASSERT_TRUE(message != NULL); 36 ASSERT_TRUE(message != NULL);
37 37
38 Tuple1<FormData> forms; 38 Tuple2<FormData, int64> forms; // also includes timestamp, which is ignored
39 AutofillHostMsg_FormSubmitted::Read(message, &forms); 39 AutofillHostMsg_FormSubmitted::Read(message, &forms);
40 ASSERT_EQ(2U, forms.a.fields.size()); 40 ASSERT_EQ(2U, forms.a.fields.size());
41 41
42 webkit_glue::FormField& form_field = forms.a.fields[0]; 42 webkit_glue::FormField& form_field = forms.a.fields[0];
43 EXPECT_EQ(WebString("fname"), form_field.name); 43 EXPECT_EQ(WebString("fname"), form_field.name);
44 EXPECT_EQ(WebString("Rick"), form_field.value); 44 EXPECT_EQ(WebString("Rick"), form_field.value);
45 45
46 form_field = forms.a.fields[1]; 46 form_field = forms.a.fields[1];
47 EXPECT_EQ(WebString("lname"), form_field.name); 47 EXPECT_EQ(WebString("lname"), form_field.name);
48 EXPECT_EQ(WebString("Deckard"), form_field.value); 48 EXPECT_EQ(WebString("Deckard"), form_field.value);
(...skipping 27 matching lines...) Expand all
76 76
77 // Submit the form. 77 // Submit the form.
78 ExecuteJavaScript("document.getElementById('myForm').submit();"); 78 ExecuteJavaScript("document.getElementById('myForm').submit();");
79 ProcessPendingMessages(); 79 ProcessPendingMessages();
80 80
81 // No FormSubmitted message should have been sent. 81 // No FormSubmitted message should have been sent.
82 const IPC::Message* message = render_thread_.sink().GetFirstMessageMatching( 82 const IPC::Message* message = render_thread_.sink().GetFirstMessageMatching(
83 AutofillHostMsg_FormSubmitted::ID); 83 AutofillHostMsg_FormSubmitted::ID);
84 ASSERT_TRUE(message != NULL); 84 ASSERT_TRUE(message != NULL);
85 85
86 Tuple1<FormData> forms; 86 Tuple2<FormData, int64> forms; // also includes timestamp, which is ignored
87 AutofillHostMsg_FormSubmitted::Read(message, &forms); 87 AutofillHostMsg_FormSubmitted::Read(message, &forms);
88 ASSERT_EQ(1U, forms.a.fields.size()); 88 ASSERT_EQ(1U, forms.a.fields.size());
89 89
90 webkit_glue::FormField& form_field = forms.a.fields[0]; 90 webkit_glue::FormField& form_field = forms.a.fields[0];
91 EXPECT_EQ(WebString("fname"), form_field.name); 91 EXPECT_EQ(WebString("fname"), form_field.name);
92 EXPECT_EQ(WebString("Rick"), form_field.value); 92 EXPECT_EQ(WebString("Rick"), form_field.value);
93 } 93 }
94 94
95 // Tests that submitting a form that has been dynamically set as autocomplete 95 // Tests that submitting a form that has been dynamically set as autocomplete
96 // off does not generate a FormSubmitted message. 96 // off does not generate a FormSubmitted message.
(...skipping 15 matching lines...) Expand all
112 EXPECT_FALSE(form.autoComplete()); 112 EXPECT_FALSE(form.autoComplete());
113 113
114 // Submit the form. 114 // Submit the form.
115 ExecuteJavaScript("document.getElementById('myForm').submit();"); 115 ExecuteJavaScript("document.getElementById('myForm').submit();");
116 ProcessPendingMessages(); 116 ProcessPendingMessages();
117 117
118 // No FormSubmitted message should have been sent. 118 // No FormSubmitted message should have been sent.
119 EXPECT_FALSE(render_thread_.sink().GetFirstMessageMatching( 119 EXPECT_FALSE(render_thread_.sink().GetFirstMessageMatching(
120 AutofillHostMsg_FormSubmitted::ID)); 120 AutofillHostMsg_FormSubmitted::ID));
121 } 121 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698