Add metrics to measure time elapsed between form load and form submission with or without Autofill.

chrome/browser/autofill/autofill_manager.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_H_
 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_H_
 #pragma once
 
 #include <list>
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/string16.h"
+#include "base/time.h"
 #include "chrome/browser/autofill/autofill_download.h"
 #include "chrome/browser/autofill/field_types.h"
 #include "chrome/browser/autofill/form_structure.h"
 #include "content/browser/tab_contents/tab_contents_observer.h"
 
 class AutofillField;
 class AutofillProfile;
 class AutofillMetrics;
 class CreditCard;
 class PersonalDataManager;
@@ skipping 76 matching lines @@
   // cards sent to and from the renderer process.
   virtual int GUIDToID(const GUIDPair& guid);
   virtual const GUIDPair IDToGUID(int id);
 
   // Methods for packing and unpacking credit card and profile IDs for sending
   // and receiving to and from the renderer process.
   int PackGUIDs(const GUIDPair& cc_guid, const GUIDPair& profile_guid);
   void UnpackGUIDs(int id, GUIDPair* cc_guid, GUIDPair* profile_guid);
 
  private:
-  void OnFormSubmitted(const webkit_glue::FormData& form);
+  void OnFormSubmitted(const webkit_glue::FormData& form,
+                       int64 timestamp);

[jar (doing other things), 2011/08/31 17:02:21]

The name timestamp is is not defined.  You should at a minimimum have a comment
indicating what this argument is.  After reading a lot of this CL, I concluded
that it is probably the internal representation of a TimeTicks().   If possible,
it would be much nicer to consistently use TimeTicks(), and only serialize when
absolutely necessary, rather than defining interfaces which pass around the
internal value as some integral type.

It also was not clear why you needed to augment the time.h class to deserialize
TimeDelta values.  Is that being done in this CL somewhere?

[Ilya Sherman, 2011/08/31 21:56:23]

The timestamp is being serialized for IPC communication, but you're right that
there's a better place to do that serialization.  Done.
It's being used to set mock expectations in the unit tests.  I've also updated
the IPC serialization code to use this.

   void OnFormsSeen(const std::vector<webkit_glue::FormData>& forms);
   void OnTextFieldDidChange(const webkit_glue::FormData& form,
-                            const webkit_glue::FormField& field);
+                            const webkit_glue::FormField& field,
+                            uint64 timestamp);
   void OnQueryFormFieldAutofill(int query_id,
                                 const webkit_glue::FormData& form,
                                 const webkit_glue::FormField& field);
   void OnFillAutofillFormData(int query_id,
                               const webkit_glue::FormData& form,
                               const webkit_glue::FormField& field,
                               int unique_id);
   void OnShowAutofillDialog();
   void OnDidPreviewAutofillFormData();
-  void OnDidFillAutofillFormData();
+  void OnDidFillAutofillFormData(uint64 timestamp);
   void OnDidShowAutofillSuggestions(bool is_new_popup);
 
   // Fills |host| with the RenderViewHost for this tab.
   // Returns false if Autofill is disabled or if the host is unavailable.
   bool GetHost(const std::vector<AutofillProfile*>& profiles,
                const std::vector<CreditCard*>& credit_cards,
                RenderViewHost** host) const WARN_UNUSED_RESULT;
 
   // Fills |form_structure| cached element corresponding to |form|.
   // Returns false if the cached element was not found.
@@ skipping 86 matching lines @@
   bool has_logged_address_suggestions_count_;
   // Have we shown Autofill suggestions at least once?
   bool did_show_suggestions_;
   // Has the user manually edited at least one form field among the autofillable
   // ones?
   bool user_did_type_;
   // Has the user autofilled a form on this page?
   bool user_did_autofill_;
   // Has the user edited a field that was previously autofilled?
   bool user_did_edit_autofilled_field_;
+  // When the user first interacted with a potentially fillable form on this
+  // page.
+  base::TimeTicks initial_interaction_timestamp_;
 
   // Our copy of the form data.
   ScopedVector<FormStructure> form_structures_;
 
   // GUID to ID mapping.  We keep two maps to convert back and forth.
   std::map<GUIDPair, int> guid_id_map_;
   std::map<int, GUIDPair> id_guid_map_;
 
   friend class AutofillManagerTest;
   friend class FormStructureBrowserTest;
@@ skipping 24 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, AutofillIsEnabledAtPageLoad);
   FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest,
                            NoQualityMetricsForNonAutofillableForms);
   FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, QualityMetrics);
   FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, QualityMetricsForFailure);
   FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, QualityMetricsWithExperimentId);
   FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, SaneMetricsWithCacheMismatch);
   FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest,
                            UserHappinessFormLoadAndSubmission);
   FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, UserHappinessFormInteraction);
+  FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, FormFillDuration);
 
   DISALLOW_COPY_AND_ASSIGN(AutofillManager);
 };
 
 #endif  // CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_H_