Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 7740064: fix content_browser dependencies to work in component build: add (Closed)

Created:
9 years, 3 months ago by Dirk Pranke
Modified:
9 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

fix content_browser dependencies to work in component build: add dependency on crypto (needed by downloads), http_server (needed by the debugger), and fix the additional libraries for geolocation so that they get picked up either by the current target (content.dll) or the dependent target (content.lib inside chrome.dll) R=darin@chromium.org BUG=90442 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99857

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M content/content_browser.gypi View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dirk Pranke
Hi Darin (or John) Can you take a look at this change? The first two ...
9 years, 3 months ago (2011-08-30 22:40:35 UTC) #1
darin (slow to review)
9 years, 3 months ago (2011-08-30 23:40:53 UTC) #2
LGTM

I would probably move those -lfoo.lib to be #pragma comment("lib", "foo.lib")

Powered by Google App Engine
This is Rietveld 408576698