chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm - Issue 7740060: [Mac] Tear down extension-installed bubble before main window closes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

Issue 7740060: [Mac] Tear down extension-installed bubble before main window closes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add unit test. Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

index d5e22c3fba7ec0c7c31db3f36ef6fbf3d06b7b80..a42aa3d43d2b31af65f3ec01ff7a92a67573e9b1 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

@@ -171,15 +171,7 @@ class DevtoolsNotificationBridge : public NotificationObserver {

}

- (void)close {

- [parentWindow_ removeChildWindow:[self window]];

- // No longer have a parent window, so nil out the pointer and deregister for

- // notifications.

- NSNotificationCenter* center = [NSNotificationCenter defaultCenter];

- [center removeObserver:self

- name:NSWindowWillCloseNotification

- object:parentWindow_];

- parentWindow_ = nil;

+ [[[self window] parentWindow] removeChildWindow:[self window]];

[super close];

}