[Mac] Tear down extension-installed bubble before main window closes.

chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller_unittest.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/basictypes.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/path_service.h"
 #include "base/values.h"
 #import "chrome/browser/ui/browser_window.h"
 #import "chrome/browser/ui/cocoa/browser_test_helper.h"
 #import "chrome/browser/ui/cocoa/cocoa_test_helper.h"
 #import "chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.h"
+#import "chrome/browser/ui/cocoa/info_bubble_window.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_constants.h"
+#include "third_party/ocmock/gtest_support.h"
+#import "third_party/ocmock/OCMock/OCMock.h"
 #include "webkit/glue/image_decoder.h"
 
 // ExtensionInstalledBubbleController with removePageActionPreview overridden
 // to a no-op, because pageActions are not yet hooked up in the test browser.
 @interface ExtensionInstalledBubbleControllerForTest :
     ExtensionInstalledBubbleController {
 }
 
 // Do nothing, because browser window is not set up with page actions
 // for unit testing.
@@ skipping 163 matching lines @@
       extension_installed_bubble::kOuterVerticalMargin);
   NSRect msg1Frame = [controller getExtensionInstalledMsgFrame];
   // Top message should start kInnerVerticalMargin pixels above top of
   //  extensionInstalled message, because page action message is hidden.
   EXPECT_EQ(msg1Frame.origin.y,
             msg3Frame.origin.y + msg3Frame.size.height +
                 extension_installed_bubble::kInnerVerticalMargin);
 
   [controller close];
 }
+
+TEST_F(ExtensionInstalledBubbleControllerTest, ParentClose) {
+  extension_ = CreateExtension(extension_installed_bubble::kBrowserAction);
+  ExtensionInstalledBubbleControllerForTest* controller =
+      [[ExtensionInstalledBubbleControllerForTest alloc]
+          initWithParentWindow:window_
+                     extension:extension_.get()
+                       browser:browser_
+                          icon:icon_];
+  EXPECT_TRUE(controller);
+
+  // Bring up the window and disable close animation.
+  [controller showWindow:nil];
+  NSWindow* bubbleWindow = [controller window];
+  ASSERT_TRUE([bubbleWindow isKindOfClass:[InfoBubbleWindow class]]);
+  [static_cast<InfoBubbleWindow*>(bubbleWindow) setDelayOnClose:NO];
+
+  // Observe whether the bubble window closes.
+  NSString* notification = NSWindowWillCloseNotification;
+  id observer = [OCMockObject observerMock];
+  [[observer expect] notificationWithName:notification object:bubbleWindow];
+  [[NSNotificationCenter defaultCenter]
+    addMockObserver:observer name:notification object:bubbleWindow];

[Scott Hess - ex-Googler, 2011/09/03 14:07:21]

I notice that the notifications need to be removed after closing the window...

+
+  // The bubble window goes from visible to not-visible.
+  EXPECT_TRUE([bubbleWindow isVisible]);
+  [window_ close];
+  EXPECT_FALSE([bubbleWindow isVisible]);
+
+  // And the appropriate notification was received.
+  EXPECT_OCMOCK_VERIFY(observer);
+}