Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: base/mac/mac_util_unittest.mm

Issue 7740055: Set user-visible machine names and devices types for synced sessions. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Split off platform-specific code to various util files, addressed comments Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/mac/mac_util_unittest.mm
diff --git a/base/mac/mac_util_unittest.mm b/base/mac/mac_util_unittest.mm
index dd860a66872930868b8dd12e856c57d50101696f..48b6fe87f42dd40660e27ebd165e5b6b368b610e 100644
--- a/base/mac/mac_util_unittest.mm
+++ b/base/mac/mac_util_unittest.mm
@@ -161,6 +161,13 @@ TEST_F(MacUtilTest, NSObjectRetainRelease) {
EXPECT_EQ(1U, [array retainCount]);
}
+// The test is somewhat silly, and just verifies that we return a hardware
+// model name.
+TEST_F(MacUtilTest, GetHardwareModelName) {
+ std::string hardware_model = GetHardwareModelName();
+ EXPECT_TRUE(!hardware_model.empty());
+}
+
TEST_F(MacUtilTest, IsOSEllipsis) {
int32 major, minor, bugfix;
base::SysInfo::OperatingSystemVersionNumbers(&major, &minor, &bugfix);

Powered by Google App Engine
This is Rietveld 408576698