Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: chrome/browser/sync/glue/session_model_associator.h

Issue 7740055: Set user-visible machine names and devices types for synced sessions. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Set device_type for SessionHeader Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/session_model_associator.h
diff --git a/chrome/browser/sync/glue/session_model_associator.h b/chrome/browser/sync/glue/session_model_associator.h
index 957914077c88c591cc34f5e7f4e8b9d79e3008e5..7a521203c448351af614e8d8ef81aa1b852291ab 100644
--- a/chrome/browser/sync/glue/session_model_associator.h
+++ b/chrome/browser/sync/glue/session_model_associator.h
@@ -191,8 +191,11 @@ class SessionModelAssociator
WriteForeignSessionToNode);
FRIEND_TEST_ALL_PREFIXES(ProfileSyncServiceSessionTest, TabNodePoolEmpty);
FRIEND_TEST_ALL_PREFIXES(ProfileSyncServiceSessionTest, TabNodePoolNonEmpty);
+ FRIEND_TEST_ALL_PREFIXES(SessionModelAssociatorTest, PopulateSessionHeader);
FRIEND_TEST_ALL_PREFIXES(SessionModelAssociatorTest, PopulateSessionWindow);
FRIEND_TEST_ALL_PREFIXES(SessionModelAssociatorTest, PopulateSessionTab);
+ FRIEND_TEST_ALL_PREFIXES(SessionModelAssociatorTest,
+ InitializeCurrentMachineName);
// Keep all the links to local tab data in one place.
class TabLinks {
@@ -321,6 +324,9 @@ class SessionModelAssociator
// Initializes the tag corresponding to this machine.
void InitializeCurrentMachineTag(sync_api::WriteTransaction* trans);
+ // Initializes the user visible name for this machine
+ static void InitializeCurrentMachineName();
+
// Updates the server data based upon the current client session. If no node
// corresponding to this machine exists in the sync model, one is created.
void UpdateSyncModelDataFromClient();
@@ -338,6 +344,12 @@ class SessionModelAssociator
const int64 sync_id,
sync_api::WriteTransaction* trans);
+ // Used to populate a session header from the session specifics header
+ // provided.
+ static void PopulateSessionHeaderFromSpecifics(
+ const sync_pb::SessionHeader& header_specifics,
+ SyncedSession* session_header);
+
// Used to populate a session window from the session specifics window
// provided. Tracks any foreign session data created through |tracker|.
static void PopulateSessionWindowFromSpecifics(
@@ -398,6 +410,9 @@ class SessionModelAssociator
// Local client name.
Nicolas Zea 2011/08/30 21:29:58 Change to "Unique client tag"
Yaron 2011/08/31 03:26:12 Done.
std::string current_machine_tag_;
+ // User-visible machine name.
+ static std::string current_machine_name_;
+
// Pool of all used/available sync nodes associated with tabs.
TabNodePool tab_pool_;

Powered by Google App Engine
This is Rietveld 408576698