Set user-visible machine names and devices types for synced sessions.

base/win/win_util.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // =============================================================================
 // PLEASE READ
 //
 // In general, you should not be adding stuff to this file.

[darin (slow to review), 2011/08/31 05:52:01]

this seems like appropriate advice in this case.  why bother adding code to
base?

wouldn't it be fine to just create a file in sync/glue/ for this?  maybe give it
a more domain specific name?

[Yaron, 2011/08/31 23:23:22]

This was based on feedback in the original review about making this more generic
but point taken. I suppose the next person wanting the computer name will see
it's already implemented and re-use it. Interestingly enough, the same comment
is not present in mac_util.h but I'll do the same there. 

 //
 // - If your thing is only used in one place, just put it in a reasonable
 //   location in or near that one place. It's nice you want people to be able
 //   to re-use your function, but realistically, if it hasn't been necessary
 //   before after so many years of development, it's probably not going to be
 //   used in other places in the future unless you know of them now.
 //
 // - If your thing is used by multiple callers and is UI-related, it should
 //   probably be in app/win/ instead. Try to put it in the most specific file
 //   possible (avoiding the *_util files when practical).
@@ skipping 33 matching lines @@
 
 // Returns true if the shift key is currently pressed.
 BASE_EXPORT bool IsShiftPressed();
 
 // Returns true if the ctrl key is currently pressed.
 BASE_EXPORT bool IsCtrlPressed();
 
 // Returns true if the alt key is currently pressed.
 BASE_EXPORT bool IsAltPressed();
 
+// Returns the computer name or the empty string an error occurred.
+BASE_EXPORT std::string GetComputerName();
+
 // Returns false if user account control (UAC) has been disabled with the
 // EnableLUA registry flag. Returns true if user account control is enabled.
 // NOTE: The EnableLUA registry flag, which is ignored on Windows XP
 // machines, might still exist and be set to 0 (UAC disabled), in which case
 // this function will return false. You should therefore check this flag only
 // if the OS is Vista or later.
 BASE_EXPORT bool UserAccountControlIsEnabled();
 
 // Sets the application id in given IPropertyStore. The function is intended
 // for tagging application/chromium shortcut, browser window and jump list for
@@ skipping 12 matching lines @@
 // Reads the command specified by |name| from the AutoRun key. |root_key|
 // could be HKCU or HKLM or the root of any user hive. Used for unit-tests.
 BASE_EXPORT bool ReadCommandFromAutoRun(HKEY root_key,
                                         const string16& name,
                                         string16* command);
 
 }  // namespace win
 }  // namespace base
 
 #endif  // BASE_WIN_WIN_UTIL_H_