Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 7740052: Add IDL for the fullscreen dev API. (Closed)

Created:
9 years, 4 months ago by brettw
Modified:
9 years, 4 months ago
Reviewers:
noelallen1, piman
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Add IDL for the fullscreen dev API and automatically generate the .h file. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98465

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -17 lines) Patch
A ppapi/api/dev/ppb_fullscreen_dev.idl View 1 1 chunk +48 lines, -0 lines 1 comment Download
M ppapi/c/dev/ppb_fullscreen_dev.h View 1 2 1 chunk +39 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
brettw
9 years, 4 months ago (2011-08-26 17:52:43 UTC) #1
noelallen1
The string is slightly different (DEV) vs _Dev. Shouldn't matter so LGTM. http://codereview.chromium.org/7740052/diff/2001/ppapi/c/dev/ppb_fullscreen_dev.h File ppapi/c/dev/ppb_fullscreen_dev.h ...
9 years, 4 months ago (2011-08-26 17:57:38 UTC) #2
piman
http://codereview.chromium.org/7740052/diff/2001/ppapi/c/dev/ppb_fullscreen_dev.h File ppapi/c/dev/ppb_fullscreen_dev.h (right): http://codereview.chromium.org/7740052/diff/2001/ppapi/c/dev/ppb_fullscreen_dev.h#newcode17 ppapi/c/dev/ppb_fullscreen_dev.h:17: #define PPB_FULLSCREEN_DEV_INTERFACE_0_4 "PPB_Fullscreen_Dev;0.4" On 2011/08/26 17:57:38, noelallen1 wrote: > ...
9 years, 4 months ago (2011-08-26 18:07:15 UTC) #3
brettw
New snap up with no generator changes (this was Noel's patch) and the interface string ...
9 years, 4 months ago (2011-08-26 18:14:42 UTC) #4
noelallen1
LGTM
9 years, 4 months ago (2011-08-26 18:27:22 UTC) #5
piman
9 years, 4 months ago (2011-08-26 18:29:27 UTC) #6
LGTM, thanks for the update.

http://codereview.chromium.org/7740052/diff/8/ppapi/api/dev/ppb_fullscreen_de...
File ppapi/api/dev/ppb_fullscreen_dev.idl (right):

http://codereview.chromium.org/7740052/diff/8/ppapi/api/dev/ppb_fullscreen_de...
ppapi/api/dev/ppb_fullscreen_dev.idl:8: * This file defines the
<code>PPB_Fullscreen</dev> interface.
qq: is <code>...</dev> intended ?

Powered by Google App Engine
This is Rietveld 408576698