Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: test/mjsunit/debug-script.js

Issue 7740050: Only count uniquely named native scripts for debug. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2008 the V8 project authors. All rights reserved. 1 // Copyright 2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 16 matching lines...) Expand all
27 27
28 // Flags: --expose-debug-as debug --expose-gc 28 // Flags: --expose-debug-as debug --expose-gc
29 // Get the Debug object exposed from the debug context global object. 29 // Get the Debug object exposed from the debug context global object.
30 Debug = debug.Debug 30 Debug = debug.Debug
31 31
32 Date(); 32 Date();
33 RegExp(); 33 RegExp();
34 34
35 // Count script types. 35 // Count script types.
36 var named_native_count = 0; 36 var named_native_count = 0;
37 var named_native_names = {};
37 var extension_count = 0; 38 var extension_count = 0;
38 var normal_count = 0; 39 var normal_count = 0;
39 var scripts = Debug.scripts(); 40 var scripts = Debug.scripts();
40 for (i = 0; i < scripts.length; i++) { 41 for (i = 0; i < scripts.length; i++) {
41 if (scripts[i].type == Debug.ScriptType.Native) { 42 if (scripts[i].type == Debug.ScriptType.Native) {
42 if (scripts[i].name) { 43 if (scripts[i].name) {
43 named_native_count++; 44 // TODO(1641): Remove check for equally named native scripts once the
45 // underlying issue is fixed.
46 if (!named_native_names[scripts[i].name]) {
47 named_native_names[scripts[i].name] = true;
48 named_native_count++;
49 }
44 } 50 }
45 } else if (scripts[i].type == Debug.ScriptType.Extension) { 51 } else if (scripts[i].type == Debug.ScriptType.Extension) {
46 extension_count++; 52 extension_count++;
47 } else if (scripts[i].type == Debug.ScriptType.Normal) { 53 } else if (scripts[i].type == Debug.ScriptType.Normal) {
48 normal_count++; 54 normal_count++;
49 } else { 55 } else {
50 assertUnreachable('Unexpected type ' + scripts[i].type); 56 assertUnreachable('Unexpected type ' + scripts[i].type);
51 } 57 }
52 } 58 }
53 59
(...skipping 29 matching lines...) Expand all
83 } 89 }
84 90
85 // Test a normal script. 91 // Test a normal script.
86 var mjsunit_js_script = Debug.findScript(/mjsunit.js/); 92 var mjsunit_js_script = Debug.findScript(/mjsunit.js/);
87 assertTrue(/mjsunit.js/.test(mjsunit_js_script.name)); 93 assertTrue(/mjsunit.js/.test(mjsunit_js_script.name));
88 assertEquals(Debug.ScriptType.Normal, mjsunit_js_script.type); 94 assertEquals(Debug.ScriptType.Normal, mjsunit_js_script.type);
89 95
90 // Check a nonexistent script. 96 // Check a nonexistent script.
91 var dummy_script = Debug.findScript('dummy.js'); 97 var dummy_script = Debug.findScript('dummy.js');
92 assertTrue(typeof dummy_script == 'undefined'); 98 assertTrue(typeof dummy_script == 'undefined');
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698