Issue 7740049: Fixed regression introduced in r9023.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7740049: Fixed regression introduced in r9023. (Closed)

Created:
9 years, 4 months ago by Yang

Modified:
9 years, 4 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fixed regression introduced in r9023. Committed: http://code.google.com/p/v8/source/detail?r=9026

Patch Set 1 #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	src/ia32/code-stubs-ia32.cc	View		3 chunks	+4 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

PTAL. http://codereview.chromium.org/7740049/diff/1/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/7740049/diff/1/src/ia32/code-stubs-ia32.cc#newcode2473 src/ia32/code-stubs-ia32.cc:2473: IntegerConvert(masm, edx, use_sse3, conversion_failure); Turned out that IntegerConvert ...

9 years, 4 months ago (2011-08-26 11:53:30 UTC) #1

LGTM

Expand Messages | Collapse Messages