chrome/browser/ui/browser.cc - Issue 7740047: DevTool: [OS_CHROMEOS] window doesn't open after detaching it for the current tab.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.cc

Issue 7740047: DevTool: [OS_CHROMEOS] window doesn't open after detaching it for the current tab. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser.cc

diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc

index 8d3dea9fe931ab20e5d2bb50f5dd2003eaea8acc..6c970ede7b6fc2c9b444ee75b48bd58c5360ea8a 100644

--- a/chrome/browser/ui/browser.cc

+++ b/chrome/browser/ui/browser.cc

@@ -465,7 +465,11 @@ Browser* Browser::CreateForApp(Type type,

// static

Browser* Browser::CreateForDevTools(Profile* profile) {

+#if defined(OS_CHROMEOS)

+ CreateParams params(TYPE_TABBED, profile);

+#else

CreateParams params(TYPE_POPUP, profile);

+#endif

params.app_name = DevToolsWindow::kDevToolsApp;

return CreateWithParams(params);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »