Issue 7740046: Changed the order of arguments in the check as suggested to issue 1341.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7740046: Changed the order of arguments in the check as suggested to issue 1341. (Closed)

Created:
9 years, 4 months ago by Yang

Modified:
9 years, 4 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Changed the order of arguments in the check as suggested to issue 1341. BUG=v8:1341 Committed: http://code.google.com/p/v8/source/detail?r=9024

Patch Set 1 #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -11 lines)			Patch
	M	test/cctest/test-api.cc	View		2 chunks	+11 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

The issue is described here: http://code.google.com/p/v8/issues/detail?id=1275 Please take a look.

9 years, 4 months ago (2011-08-26 08:28:12 UTC) #1

ulan

On 2011/08/26 08:28:12, Yang wrote: > The issue is described here: > http://code.google.com/p/v8/issues/detail?id=1275 > > ...

9 years, 4 months ago (2011-08-26 08:39:30 UTC) #2

ulan

9 years, 4 months ago (2011-08-26 08:44:10 UTC) #3

On 2011/08/26 08:39:30, ulan wrote:
> On 2011/08/26 08:28:12, Yang wrote:
> > The issue is described here:
> > http://code.google.com/p/v8/issues/detail?id=1275
> > 
> > Please take a look.
> Test

LGTM

Expand Messages | Collapse Messages