Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3698)

Unified Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 7740044: Implement fullscreen info bubble on Win and Mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix license Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/panels/panel.cc ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/frame/browser_view.h
diff --git a/chrome/browser/ui/views/frame/browser_view.h b/chrome/browser/ui/views/frame/browser_view.h
index 91db5368e99a4e11c939bb173824002e5c6cd37c..0bd8f51a6830e3959f7d6cc822ecff77901a2c81 100644
--- a/chrome/browser/ui/views/frame/browser_view.h
+++ b/chrome/browser/ui/views/frame/browser_view.h
@@ -254,7 +254,8 @@ class BrowserView : public BrowserBubbleHost,
virtual gfx::Rect GetBounds() const OVERRIDE;
virtual bool IsMaximized() const OVERRIDE;
virtual bool IsMinimized() const OVERRIDE;
- virtual void SetFullscreen(bool fullscreen) OVERRIDE;
+ virtual void EnterFullscreen(const GURL& url, bool ask_permission) OVERRIDE;
+ virtual void ExitFullscreen() OVERRIDE;
virtual bool IsFullscreen() const OVERRIDE;
virtual LocationBar* GetLocationBar() const OVERRIDE;
virtual void SetFocusToLocationBar(bool select_all) OVERRIDE;
@@ -498,7 +499,11 @@ class BrowserView : public BrowserBubbleHost,
// full screen state. On Linux changing the fullscreen state is async, so we
// ask the window to change it's fullscreen state, then when we get
// notification that it succeeded this method is invoked.
- void ProcessFullscreen(bool fullscreen);
+ // If |url| is not empty, it is the URL of the page that requested fullscreen
+ // (via the fullscreen JS API).
+ // |ask_permission| determines whether the user should be asked to allow the
+ // site to remain fullscreen.
+ void ProcessFullscreen(bool fullscreen, const GURL& url, bool ask_permission);
// Copy the accelerator table from the app resources into something we can
// use.
« no previous file with comments | « chrome/browser/ui/panels/panel.cc ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698