Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: chrome/browser/ui/fullscreen_exit_bubble.cc

Issue 7740044: Implement fullscreen info bubble on Win and Mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: respond to comments Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/fullscreen_exit_bubble.cc
diff --git a/chrome/browser/ui/fullscreen_exit_bubble.cc b/chrome/browser/ui/fullscreen_exit_bubble.cc
index a394d9004626ed64557455c2856a33a486cdd64b..8bca0a9b6320887f3470f12a43dc30fa98797186 100644
--- a/chrome/browser/ui/fullscreen_exit_bubble.cc
+++ b/chrome/browser/ui/fullscreen_exit_bubble.cc
@@ -5,9 +5,9 @@
#include "chrome/browser/ui/fullscreen_exit_bubble.h"
#include "chrome/app/chrome_command_ids.h"
+#include "chrome/browser/ui/browser.h"
#include "ui/gfx/rect.h"
-const double FullscreenExitBubble::kOpacity = 0.7;
const int FullscreenExitBubble::kPaddingPx = 8;
const int FullscreenExitBubble::kInitialDelayMs = 3800;
const int FullscreenExitBubble::kIdleTimeMs = 2300;
@@ -15,10 +15,10 @@ const int FullscreenExitBubble::kPositionCheckHz = 10;
const int FullscreenExitBubble::kSlideInRegionHeightPx = 4;
const int FullscreenExitBubble::kSlideInDurationMs = 350;
const int FullscreenExitBubble::kSlideOutDurationMs = 700;
+const int FullscreenExitBubble::kPopupTopPx = 15;
-FullscreenExitBubble::FullscreenExitBubble(
- CommandUpdater::CommandUpdaterDelegate* delegate)
- : delegate_(delegate) {
+FullscreenExitBubble::FullscreenExitBubble(Browser* browser)
+ : browser_(browser) {
}
FullscreenExitBubble::~FullscreenExitBubble() {
@@ -86,5 +86,13 @@ void FullscreenExitBubble::CheckMousePosition() {
}
void FullscreenExitBubble::ToggleFullscreen() {
- delegate_->ExecuteCommand(IDC_FULLSCREEN);
+ browser_->ExecuteCommand(IDC_FULLSCREEN);
+}
+
+void FullscreenExitBubble::AcceptFullscreen(const GURL& url) {
+ browser_->OnAcceptFullscreenPermission(url);
+}
+
+void FullscreenExitBubble::CancelFullscreen() {
+ browser_->OnDenyFullscreenPermission();
}

Powered by Google App Engine
This is Rietveld 408576698