Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1647)

Unified Diff: chrome/browser/ui/cocoa/info_bubble_window.mm

Issue 7740044: Implement fullscreen info bubble on Win and Mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix ups Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/info_bubble_window.mm
diff --git a/chrome/browser/ui/cocoa/info_bubble_window.mm b/chrome/browser/ui/cocoa/info_bubble_window.mm
index 883e53099ca3a80cebf79304dd4ab6593cfa3421..fd4760ef15a83870c37a37f1145ded352a7d4c2f 100644
--- a/chrome/browser/ui/cocoa/info_bubble_window.mm
+++ b/chrome/browser/ui/cocoa/info_bubble_window.mm
@@ -94,6 +94,7 @@ class AppNotificationBridge : public NotificationObserver {
@implementation InfoBubbleWindow
@synthesize delayOnClose = delayOnClose_;
+@synthesize canBecomeKey = canBecomeKey_;
- (id)initWithContentRect:(NSRect)contentRect
styleMask:(NSUInteger)aStyle
@@ -108,6 +109,7 @@ class AppNotificationBridge : public NotificationObserver {
[self setOpaque:NO];
[self setHasShadow:YES];
delayOnClose_ = YES;
+ canBecomeKey_ = YES;
notificationBridge_.reset(new AppNotificationBridge(self));
// Start invisible. Will be made visible when ordered front.
@@ -133,10 +135,10 @@ class AppNotificationBridge : public NotificationObserver {
// According to
// http://www.cocoabuilder.com/archive/message/cocoa/2006/6/19/165953,
// NSBorderlessWindowMask windows cannot become key or main. In this
-// case, this is not a desired behavior. As an example, the bubble could have
-// buttons.
+// case, this is not necessarily a desired behavior. As an example, the
+// bubble could have buttons.
- (BOOL)canBecomeKeyWindow {
- return YES;
+ return canBecomeKey_;
}
// Lets the traffic light buttons on the browser window keep their "active"

Powered by Google App Engine
This is Rietveld 408576698